In general, ebuilds in dev-python category are prefix enabled by its python nature. It is reasonable to just whitelist dev-python. The only block ebuild is wxpython, which in prefix has aqua support. Just wondering if it is accepted to add aqua stuff to gentoo-x86. grobian, what do you think? Reproducible: Always
The python team had very strict requests that could never be completed. You could ask again, prepare a diff to gx86 and submit it to them.
The current python members may be more lenient.
Created attachment 315059 [details, diff] wxpython.patch patch for aqua use flag and code clean up with new dodoc
Created attachment 315061 [details, diff] wxpython.patch polished
You dropped a couple recent changes (eg. the CFLAGS workaround, which I don't think is the right way to fix it but that's beside the point), you might want to diff again against the latest version. + aqua? ( >=x11-libs/wxGTK-${PV}:2.8[opengl?,tiff,aqua=] ) + !aqua? ( >=x11-libs/wxGTK-${PV}:${WX_GTK_VER}[opengl?,tiff,X] ) might as well use ${WX_GTK_VER} for both... - doins "${S}"/distrib/{Py{AlaMode,Crust,Shell},XRCed}.desktop + doins distrib/{Py{AlaMode,Crust,Shell},XRCed}.desktop i'd rather leave it as is unless there is a reason you can't use "${S}". - dodir /usr/share/doc/${PF}/docs - cp -R "${DOC_S}"/docs/* "${docdir}"/docs/ - # For some reason newer API docs aren't available so use 2.8.9.2's - cp -R "${WORKDIR}"/wxPython-2.8.9.2/docs/* "${docdir}"/docs/ + dodoc -r "${DOC_S}"/docs + dodoc -r "${WORKDIR}"/wxPython-2.8.9.2/docs there would have been a reason i didn't use dodoc. i just can't remember it. :) i think there was a need to avoid compression. if so there are better ways to do it these days. i'll have a look. in any case, please don't delete comments. actually, if you limit the patch to just the prefix stuff and drop the style/qa fixes i can probably approve it right away.
(In reply to comment #5) > the CFLAGS workaround, which I don't think is the right way to fix it See http://code.google.com/p/gentoo-progress/source/detail?r=2099 (It relies on dev-lang/python patched by 21_all_distutils_c++.patch.)
Thanks! It'd be nice to have an upstreamable solution though (or is this a Gentoo-specific thing?). Can you open a new bug explaining what the problem is and how you fixed it? I'll have a look.
(In reply to comment #5) > actually, if you limit the patch to just the prefix stuff and drop the > style/qa fixes i can probably approve it right away. I cannot agree more with this.
Created attachment 322685 [details, diff] patch for wxpython-2.8.12.1.ebuild Updated version of the aqua support patch.
Created attachment 322687 [details, diff] patch for wxpython-2.9.4.1.ebuild Same for wxpython-2.9.4.1
Looks good to me, go ahead. > + [[ -e samples/embedded/embedded ]] && rm -f samples/embedded/embedded Just curious, what's this about?
hold it! dev-lang/python needs USE=aqua before this can be committed, but the python team has historically rejected the Prefix changes to their ebuilds.
(In reply to comment #12) > hold it! dev-lang/python needs USE=aqua before this can be committed, but > the python team has historically rejected the Prefix changes to their > ebuilds. I just wanted to bring this bug up to date as the ebuilds in gx86 have changed quite a bit. Without the aqua support prefix changes boil down to ${D} -> ${ED} and ${ROOT} -> ${EROOT}. Btw., repoman doesn't even complain about the missing python[aqua] dependency. (In reply to comment #11) > > + [[ -e samples/embedded/embedded ]] && rm -f samples/embedded/embedded > > Just curious, what's this about? Hmm, not 100% sure, the only difference it makes it that the embedded example is not installed.
(In reply to comment #12) > hold it! dev-lang/python needs USE=aqua before this can be committed, but > the python team has historically rejected the Prefix changes to their > ebuilds. Indeed there are more, x11-libs/pango[X,aqua=], in gx86 pango does not have the aqua flag.
I'm sorry but this needs revisiting with the latest versions of everything.
