Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 406157 - sys-process/numactl has ill defined libdir
Summary: sys-process/numactl has ill defined libdir
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-28 14:18 UTC by Kacper Kowalik (Xarthisius) (RETIRED)
Modified: 2012-03-22 20:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
respect libdir properly on exotic platforms (numactl-2.0.7-r1.diff,576 bytes, patch)
2012-02-28 14:18 UTC, Kacper Kowalik (Xarthisius) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2012-02-28 14:18:19 UTC
Created attachment 303605 [details, diff]
respect libdir properly on exotic platforms

Currently numactl does:
libdir:=${prefix}/$(shell ./getlibdir)
where "getlibdir" is a simple script based on "uname -m". Of course it utterly fails on platforms like ppc64-32ul, prefix etc.
Comment 1 SpanKY gentoo-dev 2012-02-28 16:02:47 UTC
since it could conceivably be used by the build system, we should fix it before configure/compile steps.  how about:

src_prepare() {
  echo "echo $(get_libdir)" > getlibdir
}

or:

src_prepare() {
  sed -i \
    -e "/^libdir/s:/.*:$(get_libdir):" \
    ...
}
Comment 2 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2012-02-28 17:55:45 UTC
(In reply to comment #1)
> since it could conceivably be used by the build system, we should fix it
> before configure/compile steps.  how about:
> 
> src_prepare() {
>   echo "echo $(get_libdir)" > getlibdir
> }
Acctually, that ^^ was my first implementation. I've then fallenback to passing libdir to emake just to save space. But you're right replacing getlibdir is definitely safer way.
Comment 3 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2012-03-22 20:00:38 UTC
  22 Mar 2012; Mike Frysinger <vapier@gentoo.org> numactl-2.0.7-r1.ebuild:
  Fix libdir handling and update to EAPI=4 #379849 by Agostino Sarubbo.