Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 402135 - x11-misc/spacefm-0.6.1 - unneeded dependency on x11-libs/gksu
Summary: x11-misc/spacefm-0.6.1 - unneeded dependency on x11-libs/gksu
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Julian Ospald
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-04 06:42 UTC by Samuel Bauer
Modified: 2012-02-06 00:25 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Bauer 2012-02-04 06:42:30 UTC
There a running dependency to gksu if you don't use kde flag.

!kde? ( x11-libs/gksu )

gksu is not mandatory to run spacefm.

In gentoo one can use:
ktsuss (even it's masked)
su (even it's not gui)

Keep what is Intended to be Simple that Simple
Comment 1 Julian Ospald 2012-02-04 18:11:13 UTC
i will change it to

gtk? ( x11-libs/gksu )

then, so one can simply disable the dep.
Comment 2 Samuel Bauer 2012-02-04 18:53:41 UTC
On my local machine:

emerge libgksu -pv

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild  N     ] gnome-base/orbit-2.14.19-r1  USE="-debug -doc -test" 0 kB
[ebuild  N     ] gnome-base/gconf-2.32.4  USE="introspection ldap policykit -debug -doc" 0 kB
[ebuild  N     ] gnome-base/gnome-keyring-2.32.1-r1  USE="pam -debug -doc -test" 1,582 kB
[ebuild  N     ] gnome-base/libgnome-keyring-2.32.0  USE="-debug -doc -test" 403 kB
[ebuild  N     ] x11-libs/libgksu-2.0.12-r1  USE="nls -doc -static-libs" 467 kB

Total: 5 packages (5 new), Size of downloads: 2,451 kB

So, it's seems to me more related to gnome dependency (even if gksu is not official part of gnome, just a gtk gui to libgksu)

In my opinion, the best would be to inform through an elog in post install with something like:

elog "spacefm is able to integrate graphical su:"
elog "gtk user may want to install ktsuss"
elog "gnome user may want to install gksu"
elog "kde user may want to install kdesu"
elog "if you install none terminal su will be used"

I get a bit confused when I see the gtk flag installing so much gnome deps

Another way would be to have a more specific flag, and as ktsuss is also available on gentoo (even not stable):
gtk-desktop? (x11-libs/gksu | x11-libs/ktsuss)
would avoid confusion with gtk flag that is better used to choose gtk as toolkit.

gtk-desktop? ( x11-libs
Comment 3 Julian Ospald 2012-02-04 20:17:11 UTC
Thanks for your suggestions, but I think it's more convenient to have useflags than to tell about optional dependencies in an elog-message.

The 'gtk'-flag is also used by gparted to install gksu. A 'gnome'-flag would be more confusing for non-gnome users (i.e. xfce), IMO.

It is not uncommon that gtk-apps have gnome-dependencies which does not mean that a gnome desktop environment is required.

as for ktsuss i think this is a reasonable approach:

gtk? || ( x11-libs/gksu x11-misc/ktsuss )
kde? || ( kde-base/kdesu x11-misc/ktsuss )

people who prefer ktsuss are not forced to install gksu/kdesu this way.
Comment 4 Michael Weber (RETIRED) gentoo-dev 2012-02-05 03:04:07 UTC
+  05 Feb 2012; Michael Weber <xmw@gentoo.org> spacefm-0.6.1.ebuild:
+  Fix gksu/kdesu/ktsuss deps as pointed out by Julian Ospald, (bug 402135
+  reported by Samuel BAUER)
+
Comment 5 Samuel Bauer 2012-02-05 14:05:38 UTC
It is not uncommon that gtk-apps have gnome-dependencies, but is it for the best ?

I already filled a bug about this issue in gparted, if you look closer the longdescription in metadata.xml gparted is described as :"GParted is the Gnome Partition Editor", but gtk flag is used to install gnome deps (https://bugs.gentoo.org/show_bug.cgi?id=387353).

There are also some other ebuilds confusing gnome and gtk flag. If one globally desactivate the kde flag, he doesn't need to rsync the kde directories (which saves storage space (small confs / old PC) and bandwidth :) ). With the gnome flag it is so different.

At least the metadata.xml from gparted now documents (wrong) usage of gtk flag, but it's painful to look carefully meaning of all flags (especially when the flag has a widely accepted meaning).

If every ebuild add in their dependencies some gnome dependencies through the gtk flag users will end up with a full gnome desktop installed (really not saving storage space).

Mutliplication of ebuilds confusing gtk/gnome flag leads to the argument that this confusion isn't uncommon.
Comment 6 Michael Weber (RETIRED) gentoo-dev 2012-02-05 15:06:52 UTC
Well, gksu is "gtk+ frontend for libgksu" which is "A library for integration of su into applications". So gtk USE flag means add some gtk related stuff - or leave it.

Don't confuse profile kde/gnome with having some kde/gnome particles on your xyz profile. For example, it's perfectly common that you use konsole or gnome-terminal or kstars on an otherwise default setup.

If you don't want gtk or kde integration in spacefm, you can either have ktsuss or disable corresponding use flags (on a per package basis).

Maybe it's litte annoying to eliminate use flags pulling unwanted dependencies, but that should be addressed on o broader view.

The mentioned partial sync of the tree - I don't know what to think about this - I see it rather crazy to add another trip wire.
Comment 7 Samuel Bauer 2012-02-05 16:43:10 UTC
I just try to let remember that the gtk flag is described as:
gtk - Adds support for x11-libs/gtk+ (The GIMP Toolkit)
As spacefm has mandatory dependency to x11-libs/gtk+, it shouldn't require a flag to some gtk related stuffs.
(random sample) scilab can use 2 toolkit (Xaw3d and gtk), the corresponding flag let choose which toolkit you want to use. there it fits with the flag description

> If you don't want gtk or kde integration.
If you don't want "desktop" integration
(there's a lot of desktop based on gtk, but gtk isn't a desktop
notice it's also mentioned to rather use gtk-desktop flag)

> it's litte annoying to eliminate use flags pulling unwanted dependencies
it's litte annoying to eliminate use flags pulling unaccurate dependencies

Anyway, thanks for the quick reply and changes