Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 400755 - kde-base/solid reads OpticalDisc, when the icon for the disc is queried
Summary: kde-base/solid reads OpticalDisc, when the icon for the disc is queried
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL: https://bugs.kde.org/show_bug.cgi?id=...
Whiteboard: Fixed in 4.9.2
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-25 13:59 UTC by Franz Trischberger
Modified: 2013-03-10 07:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix to prevent DVD from spinning all the time (kdelibs-4.7.2_dvd_spinup_fix.patch,1.85 KB, text/plain)
2012-01-28 13:11 UTC, Franz Trischberger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Franz Trischberger 2012-01-25 13:59:39 UTC
This results in constant spinning of the DVD-Drive when working with dolphin (or any kde-file-dialog). Makes a lot of noice, consumes power, makes the discs quite hot, makes filemanagers lag quite a lot :(

As you can read in the upstream-bug, I tracked that silly behaviour of (e.g.) dolphin down to the fact, that solid creates new OpticalDisc-Items over and over again, when UDISKS_PRESENTATION_ICON_NAME is not set - which is the case for anything udev handles (at least, here).
I think, it is a problem somewhere in udev or udisks, but I cant' say where. Solid only tries to workaround the cases, where UDISKS_PRESENTATION_ICON_NAME is not available. The patch I posted upstream just disables this workaround.

I think, this should be fixed where the problem comes from: udev or udisks. I don't have the knowledge, so I want to ask here to help fixing this issue.

This issue is #40 in the most hated kde-bugs, and I think it is not kde's fault :/

I am running udev-171-r5, kde-4.7.4, but as you can read upstream, this issue bugs people since quite some time (since kde adopted udisks). If people encounter this a lot with Gentoo, probably the patch could be applied in portage.

Reproducible: Always
Comment 1 Franz Trischberger 2012-01-28 13:11:43 UTC
Created attachment 300135 [details]
Fix to prevent DVD from spinning all the time

Uploaded the patch here, too, for direct access.
Applies fine to kdelibs-4.8.0.
Comment 2 Johannes Huber (RETIRED) gentoo-dev 2012-07-10 15:33:37 UTC
Any news on newer udisks/udev/kde version?
Comment 3 Franz Trischberger 2012-07-21 17:36:08 UTC
I updated to latest 4.9-rc to look how udisks2 does - it's even worse :( Opening dolphin takes ~10 seconds! Opening a second instance takes the same amount of time. closing that second instance makes dolphin eat 45%, udisks 35% and dbus 15% of cpu. Trying to close another dolphin-instance does not do anything, until cpu-usage dropped again.
I don't think upstream wants my patch, as they just added another special case:
https://git.reviewboard.kde.org/r/105502/

I still think this should be addressed elsewhere, but noone seems to know where. udisks? udev?
So I will modify my patch to get instant file dialogs in 4.9, again.
Comment 4 Franz Trischberger 2012-07-22 07:19:07 UTC
Just realized that even without a disk inserted dolphin needs ~7 seconds to start up, with much too high CPU-usage in dolphin,udisksd,dbus :(
Only one startup + close produced 1451 udisks2::Device-instances (of course most of them temporary, each creating a connection to the dbus). QDebusInterface- and udisks2::Device-Constructors produce the greatest costs when running dolphin, so I assume this is the bottleneck. (profiled using valgrind)
Comment 5 Michael Palimaka (kensington) gentoo-dev 2012-10-31 10:01:45 UTC
Upstream claims this is fixed, please test.
Comment 6 Franz Trischberger 2012-11-03 06:56:36 UTC
(In reply to comment #5)
> Upstream claims this is fixed, please test.

If you are talking about the caching of OpticalDisks: That does not fix the startup delay, as caching is done for each client. It also does not work in any case:
https://bugzilla.redhat.com/show_bug.cgi?id=868530
(It's also sort of funny to see this still happen, I wrote Lukas back in July, telling him exactly the same, even sending him a callgrind-log...)

Nevertheless, according to comment 21 from mentioned report, Lukas is working on a *real* fix in libsolid.
Comment 7 Andreas K. Hüttel archtester gentoo-dev 2013-03-09 18:33:41 UTC
Should be fixed in 4.9.5
Comment 8 Franz Trischberger 2013-03-10 07:39:55 UTC
I have two kde-4.9.5 systems, both still suffering from this issue. If you have further info how to get this fixed with 4.9.5 (for 4.10.x there is soliddiskscan coming up) I will try.