Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 399019 - move unpack_{pdv,makeself} and friends to an eclass
Summary: move unpack_{pdv,makeself} and friends to an eclass
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-15 19:04 UTC by Christoph Junghans
Modified: 2012-02-16 00:03 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
unpacker.eclass (unpacker.eclass,8.26 KB, text/plain)
2012-01-15 23:32 UTC, SpanKY
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Junghans gentoo-dev 2012-01-15 19:04:03 UTC
+++ This bug was initially created as a clone of Bug #384147 +++

(In reply to comment #13)
> i'd rather create an unpacker.eclass, move unpack_{pdv,makeself} there, and
> then add a default src_unpack() that handles all these various things
Comment 1 SpanKY gentoo-dev 2012-01-15 23:32:29 UTC
Created attachment 299045 [details]
unpacker.eclass
Comment 2 Christoph Junghans gentoo-dev 2012-01-16 00:51:49 UTC
Looks great. 

Suggestions:
- general
 - global variable ${UNPACKER_TAR:=tar}, so that bsdtar could be used
 - merge-in rpm support
 - global array UNPACKER_FILELIST and give it to tar

- _unpacker
  - still missing: rar, 7z, tbz, tgz

- unpacker_src_uri_depends
 - transform names to lower cases
 - [[ $# -eq 0 ]] && set -- $SRC_URI
Comment 3 SpanKY gentoo-dev 2012-02-01 20:03:52 UTC
(In reply to comment #2)

i don't see the point of allowing bsdtar.  portage doesn't either.

rpm and partial unpack list can come later.  i'll note them as todos.

i don't see the point of handling rar/7z when that is already in EAPI=0.  the point here is *not* to re-implement all of unpack().
Comment 4 Christoph Junghans gentoo-dev 2012-02-01 20:54:37 UTC
(In reply to comment #3)
> (In reply to comment #2)
> i don't see the point of handling rar/7z when that is already in EAPI=0.  the
> point here is *not* to re-implement all of unpack().
The problem with unpack() is, that it is defined in PMS, which makes it inflexible (e.g. adding lzma support for deb packages, bug #384147). Hence I would vote for making unpacker.eclass a replacement for unpack, which makes it cross-PM automatically.
Comment 5 SpanKY gentoo-dev 2012-02-02 00:41:14 UTC
it makes no sense to duplicate code that works perfectly fine since EAPI=0
Comment 6 SpanKY gentoo-dev 2012-02-16 00:03:17 UTC
we have unpacker.eclass now and eutils.eclass no longer carries these unpack_*