Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 398601 - sys-kernel/genkernel: Improve splash handling
Summary: sys-kernel/genkernel: Improve splash handling
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-01-12 05:17 UTC by Tomasz Wasiak
Modified: 2020-01-02 01:05 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Fixes for splash support in genkernel (genkernel-3.4.22.1-splash_fixes.patch,1.10 KB, patch)
2012-01-12 05:17 UTC, Tomasz Wasiak
Details | Diff
Fixes for splash support in genkernel (genkernel-3.4.22.1-splash_fixes.patch,1.12 KB, patch)
2012-01-12 05:19 UTC, Tomasz Wasiak
Details | Diff
Fixes for splash support in genkernel. (genkernel-3.4.22.1-splash_fixes.patch,1.12 KB, patch)
2012-01-12 17:17 UTC, Tomasz Wasiak
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Wasiak 2012-01-12 05:17:09 UTC
1. gen_configkernel.sh should check for CONFIG_FB_CON_DECOR in ${KERNEL_DIR}/.config
2. There is no point in appending splash if CONFIG_FRAMEBUFFER_CONSOLE is disabled, in ${KERNEL_DIR}/.config so append_splash check if it is enabled. This should be done other way - at least oldconfig should be run after gen_configkernel.sh changes ${KERNEL_DIR}/.config to resolve in-kernel dependiences or manual placing of configuration options by gen_configkernel.sh is useless.

Reproducible: Always

Steps to Reproduce:
Run genkernel --splash initramfs for kernel without FB support.
Actual Results:  
Splash is included in initramfs.

Expected Results:  
No splash in initramfs.
Comment 1 Tomasz Wasiak 2012-01-12 05:17:52 UTC
Created attachment 298709 [details, diff]
Fixes for splash support in genkernel
Comment 2 Tomasz Wasiak 2012-01-12 05:19:00 UTC
Created attachment 298711 [details, diff]
Fixes for splash support in genkernel
Comment 3 Tomasz Wasiak 2012-01-12 17:17:06 UTC
Created attachment 298777 [details, diff]
Fixes for splash support in genkernel.

Fix for previous patch
Comment 4 Thomas Deutschmann gentoo-dev Security 2020-01-02 01:05:44 UTC
This was addressed in genkernel-4: https://gitweb.gentoo.org/proj/genkernel.git/commit/?id=8ade87f50689f725e66548fedbe436c5f642c330