Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 398333 - broken conditional pam support in FindPAM.cmake module
Summary: broken conditional pam support in FindPAM.cmake module
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
: 398331 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-01-10 06:12 UTC by SpanKY
Modified: 2012-02-03 16:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge-info.log,19.13 KB, text/plain)
2012-01-10 06:12 UTC, SpanKY
Details
kcheckpass build.log (kcheckpass-build.log,13.48 KB, text/plain)
2012-01-10 06:12 UTC, SpanKY
Details
kdebase-4.8.0-pam-optional.patch (kdebase-4.8.0-pam-optional.patch,1.10 KB, patch)
2012-01-28 11:21 UTC, Michael Palimaka (kensington)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description SpanKY gentoo-dev 2012-01-10 06:12:03 UTC
i have pam stuff installed (for testing), but my system is USE=-pam.  current kcheckpass ebuild doesn't properly respect this.

# emerge -pv kcheckpass
[ebuild   R    ] kde-base/kcheckpass-4.7.4  USE="(-aqua) -debug (-kdeenablefinal) -pam" 0 kB
# emerge kcheckpass
# scanelf -qN libpam.so.0 `qlist -e kcheckpass`
libpam.so.0  /usr/lib64/kde4/libexec/kcheckpass
Comment 1 SpanKY gentoo-dev 2012-01-10 06:12:14 UTC
Created attachment 298463 [details]
emerge --info
Comment 2 SpanKY gentoo-dev 2012-01-10 06:12:57 UTC
Created attachment 298465 [details]
kcheckpass build.log
Comment 3 Andreas K. Hüttel archtester gentoo-dev 2012-01-21 23:12:59 UTC
Yep, can confirm this even in 4.8.0. Why it's happening however is still a cmake mystery...
Comment 4 Michael Palimaka (kensington) gentoo-dev 2012-01-28 11:21:23 UTC
Created attachment 300109 [details, diff]
kdebase-4.8.0-pam-optional.patch

The problem is that FindPAM and UnixAuth are being read from the live system, ignoring the patched versions in the build directory. For some reason, the custom CMAKE_MODULE_PATH is not being respected for includes.

Attached is an updated kdebase-4.0.2-pam-optional.patch that fixes this issue. This also fixes bug #398331.

Based on kdebase-4.0.2-pam-optional.patch usage it initially looks as if kscreensaver is affected. However, I cannot find any evidence that kscreensaver actually links against PAM in any way.
Comment 5 Theo Chatzimichos (RETIRED) archtester gentoo-dev Security 2012-01-28 14:37:31 UTC
Upstream is interested in a proper fix, please file a review request at git.reviewboard.kde.org
Comment 6 Michael Palimaka (kensington) gentoo-dev 2012-01-29 10:51:20 UTC
Added to reviewboard: https://git.reviewboard.kde.org/r/103818/
Comment 7 Theo Chatzimichos (RETIRED) archtester gentoo-dev Security 2012-01-29 14:12:23 UTC
*** Bug 398331 has been marked as a duplicate of this bug. ***
Comment 8 Johannes Huber (RETIRED) gentoo-dev 2012-02-03 16:14:34 UTC
Thanks all.

Fixed in =kde-base/libkworkspace-4.7.4-r2 and =kde-base/libkworkspace-4.8.0-r1. The depending pam related packages kde-base/kdm and kde-base/kcheckpass have  revision bumps also.