Bug 397609 – net-dialup/freeradius-2.1.12 creates user and group "radius" but needs "radiusd"

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Dirk Gouders 2012-01-04 08:52:39 UTC]

When trying to build freeradius-2.1.12, it fails because of missing
group "radiusd".  After renaming the (by the ebuild) created group "radius"
the next attempt fails because of the missing user "radiusd".  After
renaming the user "radius" to "radiusd" the build succeeds.


Reproducible: Always

Steps to Reproduce:
1.On a system with no radius[d] users and group try to emerge freeradius-2.1.12
2.
3.
Actual Results:  
When trying to build freeradius-2.1.12, it fails because of missing
group "radiusd".  After renaming the (by the ebuild) created group "radius"
the next attempt fails because of the missing user "radiusd".  After
renaming the user "radius" to "radiusd" the build succeeds.


Expected Results:  
The merge should succeed.

[Comment 1 Lars Wendler (Polynomial-C) (RETIRED) 2012-01-16 10:38:50 UTC]

Created attachment 299053 [details, diff]
freeradius-2.1.12.ebuild.diff

Possible fix

[Comment 2 Dirk Gouders 2012-01-16 12:21:56 UTC]

(In reply to comment #1)
> Created attachment 299053 [details, diff] [details, diff]
> freeradius-2.1.12.ebuild.diff
> 
> Possible fix

That works but can be improved:

* the sed command has no effect and can be removed
* the chown also has to be changed

See attached diff.

[Comment 3 Dirk Gouders 2012-01-16 12:23:07 UTC]

Created attachment 299061 [details, diff]
Modified diff

* the sed command has no effect and can be removed
* the chown also has to be changed

[Comment 4 Grzegorz Chwesewicz 2012-03-05 20:55:24 UTC]

(In reply to comment #3)
> Created attachment 299061 [details, diff] [details, diff]
> Modified diff
> 
> * the sed command has no effect and can be removed
> * the chown also has to be changed

I can confirm that this patch resolves problem for me, and that I also agree that we don't need that sed, because it does nothing.

[Comment 5 Lars Wendler (Polynomial-C) (RETIRED) 2012-06-14 06:50:52 UTC]

+  14 Jun 2012; Lars Wendler <[e-mail]> -freeradius-2.0.5.ebuild,
+  -freeradius-2.1.1.ebuild, -freeradius-2.1.3-r1.ebuild,
+  -freeradius-2.1.6.ebuild, -freeradius-2.1.7.ebuild,
+  -freeradius-2.1.10.ebuild, freeradius-2.1.11.ebuild,
+  freeradius-2.1.12.ebuild:
+  non-maintainer commit: Fixed bug #397609. Removed old versions.
+

[Comment 6 Malte Starostik 2012-06-18 09:41:29 UTC]

Created attachment 315641 [details]
Failure because of incomplete fix

Now it fails because src_install uses diropts ... -g radius

Please amend:

-    diropts -m0750 -o root -g radius
+    diropts -m0750 -o root -g radiusd
-    diropts -m0750 -o radius -g radius
+    diropts -m0750 -o radius -g radiusd

[Comment 7 Malte Starostik 2012-06-18 09:42:30 UTC]

Sorry for the bugspam, also s/-o radius/-o radiusd/ in the second line of course

[Comment 8 schmitt953 2012-06-21 15:10:08 UTC]

I had the same failure on 2.1.11, I will now try 2.1.12 to see if I get the same problem.

[Comment 9 schmitt953 2012-06-21 15:17:24 UTC]

Updating my last post 2.1.12 installs and 2.1.11 did not with the same errors.

[Comment 10 Jeroen Roovers (RETIRED) 2012-06-21 15:38:41 UTC]

*** Bug 422863 has been marked as a duplicate of this bug. ***

[Comment 11 Jeroen Roovers (RETIRED) 2012-07-04 00:43:59 UTC]

*** Bug 424687 has been marked as a duplicate of this bug. ***

[Comment 12 Laszlo Valko 2012-07-04 10:13:13 UTC]

(In reply to comment #11)
> *** Bug 424687 has been marked as a duplicate of this bug. ***

Guys, I'm unhappy.

First, the "solution" originally proposed by Lars broke freeradius. It created the user "radiusd", then tried to chown the directories to user "radius". That does not sound sane.

The fix was committed to the latest stable version, without naming it differently (-r1 or whatever), creating a regression: it used to compile on my clean install of 2012-01-01, now it does not compile on my clean install of 2012-07-01.

The original (Jan-01) version created the user "radiusd" and later on used the user "radiusd". That looks the sane way of doing things...

---

More than 2 weeks have passed, with the tree containing the latest stable version broken. This bug is flagged "RESOLVED FIXED", when the "result" is a noncompiling latest stable.

Two bug reports have been filed about the regression, both now flagged as a duplicate by Jeroen, so they look like "RESOLVED".
Which they are not: the latest stable of freeradius does not compile on a clean install. And the *very*same*version* used to.

Guys, please:
- reopen this bug, if those marked as duplicate are really duplicates of this, and then clean up 2.1.11 ASAP (as that's the latest stable and it does not compile now).
- if we conclude this bug is "FIXED", then those two regression bugs are not a duplicate, but a result of this bug's "solution", so mark them as appropriate.

---

From the current freeradius-2.1.11.ebuild:
pkg_setup() {
...
        enewgroup radiusd
        enewuser radiusd -1 -1 /var/log/radius radiusd
...
src_install() {
...
        diropts -m0750 -o root -g radius
        diropts -m0750 -o radius -g radius

[Comment 13 Lars Wendler (Polynomial-C) (RETIRED) 2012-07-09 09:34:32 UTC]

*** Bug 425420 has been marked as a duplicate of this bug. ***

[Comment 14 Lars Wendler (Polynomial-C) (RETIRED) 2012-07-09 09:42:21 UTC]

+*freeradius-2.1.11-r1 (09 Jul 2012)
+
+  09 Jul 2012; Lars Wendler <[e-mail]>
+  -freeradius-2.1.11.ebuild, +freeradius-2.1.11-r1.ebuild:
+  non-maintainer commit: Fix user/group bug for stable radius as well (bug
+  #397609). Revision bump committed straight to stable.
+