Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 393503 - sys-process/fcron: add systemd unit
Summary: sys-process/fcron: add systemd unit
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo systemd Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: install-systemd-unit 466642 systemd-love
  Show dependency tree
 
Reported: 2011-12-07 11:28 UTC by emil karlson
Modified: 2013-07-20 09:56 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fcron systemd unit file (fcron.service,143 bytes, text/plain)
2011-12-07 11:28 UTC, emil karlson
Details
upstream service file. (fcron.service,227 bytes, text/plain)
2011-12-07 17:07 UTC, emil karlson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description emil karlson 2011-12-07 11:28:16 UTC
Unit file attached. (tested on sys-process/fcron-1.55-r2 and
systemd-37)

This unit file does not do all the things init script does, but only runs (and stops) the cron application which is enough for user installed crontabs. Some of the tasks may or may not be assigned to systemd itself in the future.

inherit cron pam eutils systemd

src_install(){...
systemd_dounit "${FILESDIR}/fcron.service"

Reproducible: Always
Comment 1 emil karlson 2011-12-07 11:28:43 UTC
Created attachment 295071 [details]
fcron systemd unit file
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2011-12-07 13:35:38 UTC
If they want to, the systemd team might have to take care of this, as I have no clue of (nor I honestly care about) systemd myself. I can't speak for Wolfram of course.
Comment 3 SpanKY gentoo-dev 2011-12-07 15:22:04 UTC
so far, systemd files have lived with systemd, and not with packages
Comment 4 emil karlson 2011-12-07 17:07:10 UTC
Quoting mgorny on #gentoo-desktop. 
"systemd policy is to have unit files installed by packages themselves"

Upstream service file (a bit more verbose, but makes sense to me, will test later).
http://article.gmane.org/gmane.comp.sysutils.fcron.devel/66

http://news.gmane.org/gmane.comp.sysutils.fcron.devel
Comment 5 emil karlson 2011-12-07 17:07:49 UTC
Created attachment 295093 [details]
upstream service file.
Comment 6 emil karlson 2011-12-07 18:30:12 UTC
Upstream unit file tested, seems to work flawlessly.
Comment 7 Wolfram Schlich (RETIRED) gentoo-dev 2011-12-17 09:58:45 UTC
Sorry guys, I'm not (yet) using systemd, so I doubt it would make much sense if I added something I cannot test at all... :)
Comment 8 emil karlson 2011-12-19 14:13:35 UTC
Just to clarify do you mean:
"I won't add it but systemd team may add the upstream unit file so on version bump" or "Noone may add it for now"?
Comment 9 Diego Elio Pettenò (RETIRED) gentoo-dev 2011-12-19 14:29:48 UTC
I guess that the answer is "If systemd team wants to add this, feel free to do so on version bump" — but please also note (in metadata.xml) that any bug appearing on systemd-based systems will have to be triaged by them first, and only if it's unrelated to systemd handed down to us.
Comment 10 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-12-19 15:19:16 UTC
We'll handle it from this point. I'd like to ping upstream with some corrections as well.
Comment 11 Timothy Jones 2012-08-01 19:52:53 UTC
Guys, has this ever been addressed/resolved?
Comment 12 emil karlson 2012-08-02 13:28:25 UTC
(In reply to comment #11)
> Guys, has this ever been addressed/resolved?

No, upstream hasn't released the new version with the service file yet.
Comment 13 Oleg Gawriloff 2012-12-22 15:28:32 UTC
3.1.0 is released with "Added systemd service definition (thank you Reiner)@
see http://fcron.free.fr/doc/en/changes.html
Comment 14 Fabio Erculiani (RETIRED) gentoo-dev 2013-04-15 12:40:38 UTC
I committed an ebuild into the systemd-love overlay:
https://github.com/Sabayon/systemd-love/tree/master/sys-process/fcron

It uses the upstream unit file.
Comment 15 Dennis Schridde 2013-04-23 06:50:36 UTC
There also exists a service file in the systemd overlay, but it does not work with current fcron. I provided a fix in bug #466642 (but please note the additional WantedBy change that is needed - my attachment is slightly broken!).
Comment 16 Dennis Schridde 2013-05-01 12:56:03 UTC
(In reply to comment #15)
> There also exists a service file in the systemd overlay, but it does not
> work with current fcron. I provided a fix in bug #466642 (but please note
> the additional WantedBy change that is needed - my attachment is slightly
> broken!).

The fixed fcron.service was commited to the systemd overlay. It is the correct and working version without any additional changes being necessary.
Comment 17 Pacho Ramos gentoo-dev 2013-07-05 17:12:57 UTC
(In reply to Dennis Schridde from comment #16)
> (In reply to comment #15)
> > There also exists a service file in the systemd overlay, but it does not
> > work with current fcron. I provided a fix in bug #466642 (but please note
> > the additional WantedBy change that is needed - my attachment is slightly
> > broken!).
> 
> The fixed fcron.service was commited to the systemd overlay. It is the
> correct and working version without any additional changes being necessary.

I will commit in a week if nobody disagrees. Thanks
Comment 18 Pacho Ramos gentoo-dev 2013-07-13 11:07:54 UTC
+  13 Jul 2013; Pacho Ramos <pacho@gentoo.org> fcron-3.1.2.ebuild:
+  Install unit file (#393503)
+
Comment 19 emil karlson 2013-07-17 21:40:13 UTC
/usr/lib/systemd/system/fcron.init.systemd should probably be 
/usr/lib/systemd/system/fcron.service
Comment 20 emil karlson 2013-07-18 08:24:40 UTC
also we have /usr/sbin/ as sbindir and 

exeinto /usr/libexec
doexe fcron fcronsighup

and

ExecStart=@@DESTSBIN@/fcron

which will point to

/usr/sbin/fcron

making the unit file totally defunc in any case, sorry
Comment 21 Pacho Ramos gentoo-dev 2013-07-19 06:33:13 UTC
Will take care of it as soon as possible, thanks for noticing
Comment 22 Pacho Ramos gentoo-dev 2013-07-20 09:56:24 UTC
+*fcron-3.1.2-r1 (20 Jul 2013)
+
+  20 Jul 2013; Pacho Ramos <pacho@gentoo.org> +fcron-3.1.2-r1.ebuild,
+  -fcron-3.1.2.ebuild:
+  Fix unit file installation (#393503#c19 by emil karlson)
+