Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 390127 - app-portage/layman-2.0.0_rc3 ambiguous error reporting
Summary: app-portage/layman-2.0.0_rc3 ambiguous error reporting
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords: InVCS
: 430258 (view as bug list)
Depends on:
Blocks: 375789
  Show dependency tree
 
Reported: 2011-11-10 21:08 UTC by Mitch Harder
Modified: 2012-11-19 01:54 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mitch Harder 2011-11-10 21:08:19 UTC
When running 'layman -a <repo>' when you do not have the appropriate vcs installed, layman-2.0.0_rc3 gives an ambiguous error which does not indicate the problem.

Layman-1.4 would report back something like: "* Program "/usr/bin/git" not found"

This would clue you in as to the problem.

Reproducible: Always

Steps to Reproduce:
1. Run 'layman -a <repo>' when appropriate vcs is not installed.
2.
3.
Actual Results:  
# layman -a <repo>
 
 * Adding overlay,...
 * Adding repository "<repo>" failed!
 
 * CLI: Errors occured processing action add
 * Adding repository "<repo>" failed!


Expected Results:  
Example for layman-1.4.1

# layman -a <repo>
* Program "/usr/bin/git" not found
* Failed to add overlay "<repo>".
* Error was: Adding overlay "<repo>" failed!
Comment 1 Brian Dolbec (RETIRED) gentoo-dev 2011-11-16 16:12:35 UTC
I have already improved that in git.  There was a forum thread that brought the problem to my attention.  http://forums.gentoo.org/viewtopic-t-897538-highlight-layman.html.

Please try layman-9999, it has a few small changes since _rc3.
Comment 2 Brian Dolbec (RETIRED) gentoo-dev 2012-10-07 23:45:36 UTC
OK, I found where the messages were for this bug were broken.  It was due to an extra paramenter in the function call to print them.  It was causing a traceback that was hidden from view.

Fixed in commit: http://git.overlays.gentoo.org/gitweb/?p=proj/layman.git;a=commit;h=915e3c0865ecee24cb31ead94d573b397ae67c51
Comment 3 Brian Dolbec (RETIRED) gentoo-dev 2012-10-08 04:47:03 UTC
*** Bug 430258 has been marked as a duplicate of this bug. ***
Comment 4 Brian Dolbec (RETIRED) gentoo-dev 2012-11-19 01:54:43 UTC
released in layman-2.0.0_rc4 and rc5.