Created attachment 291217 [details] Test suite for scons_clean_makeopts as a dummy ebuild Hey there. While playing with function scons_clean_makeopts I discovered that it doesn't handle these two cases properly: FAILED test for '--jobs -l3' (got '--jobs -l3', expected '--jobs=5') FAILED test for '-j -l3' (got '-j -l3', expected '-j 5') These tests are mine: I abused a dummy ebuild for that, see attachment. As far as I can tell the problem is that the code if [[ ${#} -gt 1 && ${2} =~ [0-9]+ ]]; then in the eclass applies regex [0-9]+ rather than something like '^[0-9]+$'. That code appears at least twice in the eclass.
Patch title (first comment line): Fix broken number matching regexp in scons_clean_makeopts(). Autocommit cvs commit -F .msg 'scons-utils.eclass' /var/cvsroot/gentoo-x86/eclass/scons-utils.eclass,v <-- scons-utils.eclass new revision: 1.7; previous revision: 1.6 Committed successfully to CVS Thanks for the report; I've added regression tests for the bug to the test suite as well (/eclass/tests/scons-utils.sh).
Impressive response time!
(In reply to comment #2) > Impressive response time! Yes, that one is usually great when you are supposed to be doing something else ;D.
