Bug 386709 – qt_assistant_cleanup in qt4-build.eclass destroy 4.7.4 tools.pro syntax

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Laurent G. 2011-10-11 05:07:48 UTC]

Applying sed script in qt_assistant_cleanup to a fresh tools.pro (it has correct syntax) unevens curly braces (syntax is borked).

[Comment 1 Markos Chandras (RETIRED) 2011-10-26 22:18:03 UTC]

Can we have an output please?

[Comment 2 Laurent G. 2011-11-01 18:48:25 UTC]

I found that while trying to get qt-assistant 4.7.4 "by hand" because the qch compilation takes forever on my machine with this version.

It is for tools/tools.pro. Before "prepare" phase, I can see :

!contains(QT_CONFIG, no-gui) {
    no-png {
        message("Some graphics-related tools are unavailable without PNG support")
    } else {
        symbian {
            SUBDIRS = designer
        } else:wince* {
            SUBDIRS = qtestlib designer
        } else {
            SUBDIRS = assistant \
                      pixeltool \
                      porting \
                      qtestlib \
                      qttracereplay
            contains(QT_EDITION, Console) {
                SUBDIRS += designer/src/uitools     # Linguist depends on this
            } else {
                SUBDIRS += designer
            }
        }
        unix:!mac:!embedded:contains(QT_CONFIG, qt3support):SUBDIRS += qtconfig
        win32:!wince*:SUBDIRS += activeqt
    }
    contains(QT_CONFIG, declarative):SUBDIRS += qml
}



applying the sed script results in :

!contains(QT_CONFIG, no-gui) {
    no-png {
        message("Some graphics-related tools are unavailable without PNG support")
    } else {
        symbian {
            SUBDIRS = designer
        } else:wince* {
            SUBDIRS = qtestlib designer
        } else {
            SUBDIRS = assistant \
                      pixeltool qdoc3 \
    }
    contains(QT_CONFIG, declarative):SUBDIRS += qml
}

[Comment 3 Davide Pesavento (RETIRED) 2011-11-19 20:04:59 UTC]

Well, the funny thing is that tools.pro is not used in qt-assistant-4.7.4 :)
So, while it's true that qt_assistant_cleanup() patches it incorrectly, it's also true that the syntax error doesn't cause any problems at all.

Anyway, I've made qt_assistant_cleanup() a no-op in 4.7.4 and later. Thanks for reporting!

[Comment 4 Laurent G. 2011-11-26 10:24:49 UTC]

(In reply to comment #3)
> Well, the funny thing is that tools.pro is not used in qt-assistant-4.7.4 :)
> So, while it's true that qt_assistant_cleanup() patches it incorrectly, it's
> also true that the syntax error doesn't cause any problems at all.
> 
> Anyway, I've made qt_assistant_cleanup() a no-op in 4.7.4 and later. Thanks for
> reporting!

That is not so strange to me. I did not really expect a correction on that would help my case. I'd like to find out why I still can not get qt-assistant to build OK on my ppc, but I guess I'll have to wait for 4.8 or smth like that.

[Comment 5 Davide Pesavento (RETIRED) 2011-11-26 12:57:46 UTC]

You can try 4.8.0_rc1 in the qting-edge overlay if you want.