Bug 384775 – gnome-base/libglade-2.6.4 fails to compile with glib-2.30.0 due to G_CONST_RETURN in pango-1.28.4 headers

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Ian Abbott 2011-09-28 12:08:18 UTC]

The G_CONST_RETURN pre-processor macro was formally deprecated in glib-2.30.  It will not be defined if the G_DISABLE_DEPRECATED macro is defined.

The header files installed by x11-libs/pango-1.28.4 use G_CONST_RETURN.
 
gnome-base/libglade-2.6.4 indirectly depends on pango and defines G_DISABLE_DEPRECATED on the compiler command-line (see glade/Makefile.am).

Therefore, gnome-base/libglade-2.6.4 fails to compile with dev-libs/glib-2.30.0 and x11-libs/pango-1.28.4.



Reproducible: Always




$ emerge -pv1 =gnome-base/libglade-2.6.4
[ebuild   R    ] gnome-base/libglade-2.6.4  USE="doc -static-libs -test" 0 kB

$ emerge --info
Portage 2.1.10.19 (default/linux/amd64/10.0/desktop, gcc-4.5.3, glibc-2.13-r4, 3.0.4-gentoo-ija1 x86_64)
=================================================================
System uname: Linux-3.0.4-gentoo-ija1-x86_64-AMD_Athlon-tm-_64_X2_Dual_Core_Processor_3800+-with-gentoo-2.0.3
Timestamp of tree: Tue, 27 Sep 2011 14:45:01 +0000
app-shells/bash:          4.2_p10
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.7.2-r3, 3.2.2
dev-util/cmake:           2.8.5-r2
dev-util/pkgconfig:       0.26
sys-apps/baselayout:      2.0.3
sys-apps/openrc:          0.9.3-r1
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.13, 2.68
sys-devel/automake:       1.9.6-r3, 1.10.3, 1.11.1-r1
sys-devel/binutils:       2.21.1-r1
sys-devel/gcc:            3.3.6-r1, 3.4.6-r2, 4.2.4-r1, 4.3.6-r1, 4.4.6-r1, 4.5.3-r1
sys-devel/gcc-config:     1.4.1-r1
sys-devel/libtool:        2.4-r3
sys-devel/make:           3.82-r3
sys-kernel/linux-headers: 2.6.39 (virtual/os-headers)
sys-libs/glibc:           2.13-r4
Repositories: gentoo Local_portage_overlay
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=k8 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=k8 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests binpkg-logs distlocks ebuild-locks fixlafiles fixpackages news parallel-fetch protect-owned sandbox sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS=""
GENTOO_MIRRORS="http://www.mirrorservice.org/sites/www.ibiblio.org/gentoo http://gentoo.oregonstate.edu http://www.ibiblio.org/pub/Linux/distributions/gentoo"
LANG="en_GB.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en en_GB"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="X a52 aac acl acpi adns alsa amd64 avahi berkdb branding bzip2 cairo cdda cdr cgi cjk cli consolekit cracklib crypt cscope cups curl cxx dbus djvu doc dri dts dv dvd dvdr emboss encode esd exif expat fam ffmpeg firefox flac flash fontconfig fortran gdbm gdu gif glut gmp gnome gnome-keyring gnutls gpm graphviz gstreamer gtk gtkhtml guile iconv icu idn imagemagick imap imlib ipod ipv6 java jpeg kde kerberos lcms ldap libnotify mad matroska mmx mng modules mono motif mp3 mp4 mpeg mudflap multilib musicbrainz ncurses nls nptl nptlonly nsplugin offensive ogg opengl openmp pam pango pcre pdf perl plotutils png policykit ppds pppd pulseaudio python qt3support qt4 quicktime rdesktop readline ruby samba sasl sdl semantic-desktop session slang snmp spell sqlite sse sse2 ssl startup-notification svg sysfs tcl tcltk tcpd threads tiff tk truetype udev unicode usb vnc vorbis x264 xcb xine xml xorg xulrunner xv xvid zlib" ALSA_CARDS="hda-intel" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en en_GB" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="radeon ati vesa fbdev" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 1 Ian Abbott 2011-09-28 12:09:30 UTC]

Created attachment 288077 [details]
Build log

[Comment 2 Pacho Ramos 2011-09-28 12:38:24 UTC]

I guess we should use fedora patch for pango:
http://pkgs.fedoraproject.org/gitweb/?p=pango.git;a=blob;f=pango-1.28.4-stop-using-G_CONST_RETURN.patch;h=a375729029824c674b54c196f528e5df77000c98;hb=eededf8c4ac865d8b35bb87588466c648bda9b05

And continue dropping DEPRECATED flags :S

[Comment 3 Ian Abbott 2011-09-28 12:42:42 UTC]

Created attachment 288079 [details, diff]
Omit G_DISABLE_DEPRECATED pre-processor macro

This patch allows libglade to compile with glib-2.30.0 and pango-1.28.4 by removing -DG_DISABLE_DEPRECATED from the compiler command-line.

It might be better to modify the pango package to avoid using G_CONST_RETURN - see http://git.gnome.org/browse/pango/commit/?id=4c7807daee7189f481d7c18b56b06d7b7dba7884 - the patch seems to apply okay (with a few hunk offsets) to the pango-1.28.4 source.

[Comment 4 Ian Abbott 2011-09-28 13:06:39 UTC]

(In reply to comment #3)
> It might be better to modify the pango package to avoid using G_CONST_RETURN -

Bug 384779

[Comment 5 Pacho Ramos 2011-09-29 16:50:12 UTC]

+  29 Sep 2011; Pacho Ramos <[e-mail]> libglade-2.6.4.ebuild:
+  Drop DEPRECATED flags, bug #384775 by Ian Abbott.
+

[Comment 6 Alexandre Rostovtsev (RETIRED) 2011-10-01 00:06:48 UTC]

*** Bug 385099 has been marked as a duplicate of this bug. ***