Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 384311 - net-misc/bti add patch to allow compilation on non-GNU systems
Summary: net-misc/bti add patch to allow compilation on non-GNU systems
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Other
: Normal normal (vote)
Assignee: Greg Kroah-Hartman (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2011-09-24 15:52 UTC by Fabian Groffen
Modified: 2013-06-02 11:58 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
no gnu strchrnul patch (bti-031-nognustrchrnul.patch,812 bytes, patch)
2011-09-24 15:52 UTC, Fabian Groffen
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Groffen gentoo-dev 2011-09-24 15:52:13 UTC
Created attachment 287605 [details, diff]
no gnu strchrnul patch

strchrnul is a GNUism.  The attached patch removes the usage of it, such that bti can be compiled on non-GNU platforms (like Darwin, in my case).

I could only test it limited, because I only seem to be able to get "Twitter no longer supports HTTP basic authentication" error messages, which I haven't yet found out who/what/where is the problem.
Comment 1 Greg Kroah-Hartman (RETIRED) gentoo-dev 2011-09-24 16:17:54 UTC
Use the OAUTH method for twitter to verify if this works or not please

And care to send that patch upstream so it can be included there?
Comment 2 Fabian Groffen gentoo-dev 2011-09-24 16:20:34 UTC
I'll try to figure out how to tell bti to do that.

I thought you were upstream, but I can mail it to gregkh@something as well if you prefer.
Comment 3 Greg Kroah-Hartman (RETIRED) gentoo-dev 2011-09-24 16:46:22 UTC
I am upstream, but please send patches to "greg@kroah.com" so I can apply them properly to the package.

As for oauth, please read the documentation, it should show you how to do it all properly.
Comment 4 Fabian Groffen gentoo-dev 2011-09-24 17:29:18 UTC
Suggestion, put the OAuth docu also in the manpage, iso only in the README.

Anyhow, bti sigaborts, so I'l need to invest some more time in it with debugging symbols.
Comment 5 Fabian Groffen gentoo-dev 2011-09-24 18:26:14 UTC
bti works fine, nss seems to be flacky.  Sending patch upstream now
Comment 6 Pacho Ramos gentoo-dev 2012-09-23 09:36:41 UTC
(In reply to comment #5)
> bti works fine, nss seems to be flacky.  Sending patch upstream now

What did occur with this finally?
Comment 7 Pacho Ramos gentoo-dev 2013-03-03 16:54:34 UTC
Any news? Do you allow me to commit this patch?
Comment 8 Pacho Ramos gentoo-dev 2013-06-02 11:58:00 UTC
+*bti-031-r1 (02 Jun 2013)
+
+  02 Jun 2013; Pacho Ramos <pacho@gentoo.org> +bti-031-r1.ebuild,
+  +files/bti-031-nonGNU.patch:
+  Allow compilation on non-GNU systems (#384311 by Fabian Groffen)
+