Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 383695 - Buffer overflow in media-sound/grip-3.3.1-r2
Summary: Buffer overflow in media-sound/grip-3.3.1-r2
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo Sound Team
Depends on:
Reported: 2011-09-19 20:12 UTC by Michael Mol
Modified: 2018-06-27 15:15 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

emerge --info (emerge_info,5.39 KB, text/plain)
2011-09-19 20:13 UTC, Michael Mol
stack trace and memory map from overflow detection. (grip_errors,11.77 KB, text/plain)
2011-09-19 20:15 UTC, Michael Mol
grip configuration file (grip,1.47 KB, text/plain)
2011-09-19 20:31 UTC, Michael Mol
grip configuration file for lame (grip-lame,62 bytes, text/plain)
2011-09-19 20:31 UTC, Michael Mol
gdb capture of crash, including "bt full" output. (gdb.txt,13.03 KB, text/plain)
2011-09-20 00:21 UTC, Michael Mol

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Mol 2011-09-19 20:12:29 UTC
Reproducible while I try to rip a specific disc. On one occasion, it wiped out my ~/.grip file, too.

Reproducible: Always

Steps to Reproduce:
1. Launch grip
2. Configure grip (if necessary) to rip and encode on insert. (My .grip file will be provided for reference. If you use that, skip this step)
3. Insert disc
Actual Results:  
Fails with a buffer overflow exception.

Mon Sep 19 03:58 PM
!512 #12 j0 ?0 $ grip 1> grip_stdout 2>grip_error
*** buffer overflow detected ***: grip terminated
======= Backtrace: =========

[snip -- see attachments]

======= Memory map: ========

[snip -- see attachments]

Expected Results:  
It should rip and encode the disc, per configuration. It successfully does this for several other discs.
Comment 1 Michael Mol 2011-09-19 20:13:07 UTC
Created attachment 287051 [details]
emerge --info
Comment 2 Michael Mol 2011-09-19 20:15:07 UTC
Created attachment 287053 [details]
stack trace and memory map from overflow detection.

It appears to have assumed an 80-col-wide terminal. While I can repro the error as many times as I like, I couldn't get it to not wrap the stack and map. Also, redirecting 1> (somefile) and 2> (some_other_file) wound up with this information bypassing those files and being sent to the pty.
Comment 3 Michael Mol 2011-09-19 20:31:18 UTC
Created attachment 287055 [details]
grip configuration file

rename to $HOME/.grip
Comment 4 Michael Mol 2011-09-19 20:31:56 UTC
Created attachment 287057 [details]
grip configuration file for lame

rename to $HOME/.grip-lame
Comment 5 Michael Mol 2011-09-20 00:21:28 UTC
Created attachment 287095 [details]
gdb capture of crash, including "bt full" output.

It wasn't able to find the source files for some things, which I don't know the cause for, nor how to fix systemically. (I have -ggdb in my CFLAGS and splitdebug in FEATURES...I'm not averse to globally-applying debugging features. I like better debugging for less effort, personally.)
Comment 6 Pacho Ramos gentoo-dev 2018-06-27 15:15:11 UTC
please recheck with 3.8.1