Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 383431 - dev-lang/R-2.13.1 fails to build with zlib-
Summary: dev-lang/R-2.13.1 fails to build with zlib-
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo Science Mathematics related packages
Depends on: 383179
  Show dependency tree
Reported: 2011-09-17 22:57 UTC by Michael Schreckenbauer
Modified: 2011-09-25 19:36 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---

patch to fix compilation with zlib- (zlib-,410 bytes, patch)
2011-09-17 22:58 UTC, Michael Schreckenbauer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Schreckenbauer 2011-09-17 22:57:02 UTC
Same error as in bug #383351 when compiling src/main/dounzip.c

Reproducible: Always
Comment 1 Michael Schreckenbauer 2011-09-17 22:58:00 UTC
Created attachment 286835 [details, diff]
patch to fix compilation with zlib-
Comment 2 Michael Schreckenbauer 2011-09-17 22:58:20 UTC
Attached patch fixes it for me.
Comment 3 Claudio Roberto França Pereira 2011-09-18 07:15:14 UTC
I confirm the bug and the patch. Needed to mess with paths for it to work with local portage overlay, though.
Comment 4 Robert Cabrera 2011-09-18 09:36:01 UTC
I can confirm the regression with zlib- R and vlc both fail to compile with it installed. 

However, downgrading to zlib- works fine on my ~amd64 laptop.

Which is what I did to rebuild them when libpng was upgraded today and I had to recompile everything built against the old version.
Comment 5 Rainer 'Siju' Sigl 2011-09-18 17:41:15 UTC
patch works for me ~x86
Comment 6 SpanKY gentoo-dev 2011-09-19 03:26:23 UTC
Comment on attachment 286835 [details, diff]
patch to fix compilation with zlib-

this misses the whole point of the zlib change: you aren't supposed to be using these macros.

instead, add the simple one liner:
#define OF(x) x
Comment 7 Michael Schreckenbauer 2011-09-19 11:50:39 UTC
That's in the ebuild for zlib-1.2.5-r1:
# clean up namespace a little #383179

My patch uses that cleaned up namespace. If the comment in the ebuild does not describe the whole point of the change, what's the purpose of it?

Your simple on-liner generates a new warning, when compiled with zlib < 1.2.5-r1
So I'd suggest:
#ifndef OF
#define OF(x) x
Comment 8 Eric Grüttefien 2011-09-19 12:51:19 UTC
(In reply to comment #7)

works too
Comment 9 Steve Arnold archtester gentoo-dev 2011-09-25 04:02:35 UTC
The patch works, but just updating the dep (as in the vlc bug) does not.  Why don't we have a "proper" patch or updated R ebuild again?  I'm confused...
Comment 10 Steve Arnold archtester gentoo-dev 2011-09-25 19:36:34 UTC
Fixed with the patch suggested in comment #7 and an updated depend like the one in bug #383351 (the unzip dep was dropped in favor of minizip).  Seems to work as advertised (more or less) on machines with both the old and new zlib.