x86_64-pc-linux-gnu-gcc -c -pipe -O2 -pipe -march=native -Wall -W -D_REENTRANT -DDOWNLOAD_SUBS -DDATA_PATH=\"/usr/share/smplayer\" -DDOC_PATH=\"/usr/share/doc/smplayer-0.6.9-r1\" -DTRANSLATION_PATH=\"/usr/share/smplayer/translations\" -DTHEMES_PATH=\"/usr/share/smplayer/themes\" -DSHORTCUTS_PATH=\"/usr/share/smplayer/shortcuts\" -DNO_DEBUG_ON_CONSOLE -DQT_NO_DEBUG -DQT_XML_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtXml -I/usr/include/qt4 -Ifindsubtitles -Ivideopreview -Impcgui -Ifindsubtitles/filedownloader -Ifindsubtitles/quazip -I.moc -I.ui -o .obj/ioapi.o findsubtitles/quazip/ioapi.c In file included from findsubtitles/quazip/ioapi.c:14:0: findsubtitles/quazip/ioapi.h:38:44: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'OF' Reproducible: Always
Created attachment 286755 [details] build log
Created attachment 286757 [details] emerge --info
A downgrade to zlib-1.2.5.1 solves the issue. zlib-1.2.5.1-r1 renames the ON macro and that causes this bug: # clean up namespace a little #383179 # we do it here so we only have to tweak 2 files sed -i -r 's:\<(O[FN])\>:_Z_\1:g' "${D}"/usr/include/*.h
packages relying on OF/ON are broken. there's no reason to use these things as they're only for supporting old compilers.
same error here. Downgraded zlib solved the issue.
(In reply to comment #5) > same error here. > Downgraded zlib solved the issue. I can confirm that.
smplayer fails because it is actually copying the minizip code out of zlib itself, modifying it a bit, and then linking it into its own binary simple fix to add to smplayer that'll work with any zlib version: sed -i '1i#define OF(x) x' src/findsubtitles/quazip/*.h
(In reply to comment #7) > simple fix to add to smplayer that'll work with any zlib version: > sed -i '1i#define OF(x) x' src/findsubtitles/quazip/*.h simple fix worked here.
There is actually a dev-libs/quazip package/atom in portage. Shouldn't it be a dependency of smplayer? Or smplayer already has the source code for it embedded?
(In reply to comment #8) > (In reply to comment #7) > > simple fix to add to smplayer that'll work with any zlib version: > > sed -i '1i#define OF(x) x' src/findsubtitles/quazip/*.h > > simple fix worked here. Confirmed also here.
*** Bug 383667 has been marked as a duplicate of this bug. ***
dev-libs/quazip is affected, too: + 21 Sep 2011; Sebastian Pipping <sping@gentoo.org> quazip-0.4.3-r1.ebuild, + +files/quazip-0.4.3-zlib.patch: + Fix compilation against zlib-1.2.5.1-r1 (bug #383309) +
+*smplayer-0.6.9-r2 (21 Sep 2011) + + 21 Sep 2011; Sebastian Pipping <sping@gentoo.org> +smplayer-0.6.9-r2.ebuild, + +files/smplayer-0.6.9-quazip.patch: + Unbundle quazip (bug #383309), re-keywording requested (bug #383945) + Thanks to Claudio for the hint on dev-libs/quazip!
(In reply to comment #7) > simple fix to add to smplayer that'll work with any zlib version: > sed -i '1i#define OF(x) x' src/findsubtitles/quazip/*.h Assuming have a recent version of portage, it's possible to make this even simpler and avoid editing and re-manifesting the ebuild itself. Simply create a file: /etc/portage/env/media-video/smplayer-0.6.9-r1 (You can call it simply smplayer if desired, but hopefully the next version bump will include this fix, and specifying the version including the -r1 might prevent problems with later versions.) In that file, put the following three lines: post_src_prepare () { sed -i '1i#define OF(x) x' src/findsubtitles/quazip/*.h } smplayer should rebuild just fine after that. =:^) Duncan
*** Bug 383949 has been marked as a duplicate of this bug. ***
*** Bug 417591 has been marked as a duplicate of this bug. ***
*** Bug 418123 has been marked as a duplicate of this bug. ***
