Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 383149 - www-plugins/gecko-mediaplayer: please support building against net-misc/npapi-sdk
Summary: www-plugins/gecko-mediaplayer: please support building against net-misc/npapi...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Media-video project
URL: http://code.google.com/p/gecko-mediap...
Whiteboard: [mozilla-overlay supported]
Keywords:
Depends on:
Blocks: 383069 393049
  Show dependency tree
 
Reported: 2011-09-15 20:36 UTC by Michał Górny
Modified: 2011-12-04 20:48 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Complete ebuild using npapi-sdk patch (gecko-mediaplayer-1.0.4-r1.ebuild,1.20 KB, text/plain)
2011-09-15 20:47 UTC, Samuli Suominen (RETIRED)
Details
npapi-sdk.patch to files/ (npapi-sdk.patch,613 bytes, patch)
2011-09-15 20:48 UTC, Samuli Suominen (RETIRED)
Details | Diff
npapi-sdk.patch to files/ (npapi-sdk.patch,1.26 KB, text/plain)
2011-11-29 19:37 UTC, Ian Stakenvicius (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-09-15 20:36:15 UTC
NPAPI-SDK is a tiny package providing headers necessary to build NPAPI plugins without the need for emerging whole xulrunner.

Migration requires the package to check for npapi-sdk.pc as well as current headers. The pkg-config file doesn't require any additional Mozilla components, and is versioned using NPAPI versions rather than Mozilla versions.

As mentioned earlier, the package needs some rewrite. AFAICS it indirectly uses NSPR API including it through xulrunner headers.
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2011-09-15 20:47:47 UTC
Created attachment 286587 [details]
Complete ebuild using npapi-sdk patch
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2011-09-15 20:48:39 UTC
Created attachment 286589 [details, diff]
npapi-sdk.patch to files/

And fails with...

plugin.cpp:45:27: fatal error: nsIPrefBranch.h: No such file or directory
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-09-15 20:57:30 UTC
You don't need to re-state what I said in the description.
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2011-09-15 23:40:36 UTC
(In reply to comment #3)
> You don't need to re-state what I said in the description.

I wanted to save the current work here, so it won't get lost, so I can easily return to it by dl'ing the 2 attachments and go straight to the first error...

Was not meant to diminish your comment in anyway ;-)
Comment 5 Ian Stakenvicius (RETIRED) gentoo-dev 2011-11-29 19:37:06 UTC
Created attachment 294231 [details]
npapi-sdk.patch to files/

this patch applies to both 1.0.4 and 1.0.5_beta1 cleanly, and resolves the remaining header issues related to a missing xulrunner.

I would also recommend that the dep for the new ebuild be changed from an either-or on npapi-sdk or xulrunner, to an explicit =net-misc/npapi-sdk-0.27 in DEPEND.
Comment 6 Ian Stakenvicius (RETIRED) gentoo-dev 2011-11-29 20:14:26 UTC
ie, like so:


--- gecko-mediaplayer-1.0.4-r0.ebuild   2011-11-29 15:13:26.000000000 -0500
+++ gecko-mediaplayer-1.0.4-r1.ebuild   2011-11-29 14:29:42.000000000 -0500
@@ -19,10 +19,10 @@
        >=dev-libs/glib-2.26:2
        dev-libs/nspr
        >=media-video/gnome-mplayer-1.0.4[dbus]
-       || ( net-misc/npapi-sdk >=net-libs/xulrunner-1.9.2:1.9 )
        curl? ( net-misc/curl )
        !www-client/chromium"
 DEPEND="${RDEPEND}
+       =net-misc/npapi-sdk-0.27
        dev-util/pkgconfig
        sys-devel/gettext"
Comment 7 Oschtan 2011-11-30 06:15:08 UTC
Yes, everything really is compiled. Compiling the first also fails:

plugin.cpp:48:27: Fatal error: nsIPrefBranch.h: No such file or directory

But the decision was cleaning ccache
Comment 8 Samuli Suominen (RETIRED) gentoo-dev 2011-12-02 22:45:29 UTC
+*gecko-mediaplayer-1.0.5_beta1_p20111203 (02 Dec 2011)
+
+  02 Dec 2011; Samuli Suominen <ssuominen@gentoo.org>
+  +gecko-mediaplayer-1.0.5_beta1_p20111203.ebuild:
+  New snapshot to support building against npapi-sdk wrt #383149 by Ian
+  Stakenvicius (and Michał Górny for reporting)