Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 381973 - dev-games/physfs-2.0.3-r1 doesn't support 7z
Summary: dev-games/physfs-2.0.3-r1 doesn't support 7z
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: Normal enhancement with 1 vote (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-05 19:56 UTC by Oleg
Modified: 2018-03-25 19:51 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to add optional lzma support (physfs_lzma.diff,1.07 KB, patch)
2012-01-07 19:48 UTC, Peter Ebden
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg 2011-09-05 19:56:45 UTC
dev-games/physfs-2.0.2-r1 doesn't support 7z and even don't have USE flags for enabling it.

Reproducible: Always

Steps to Reproduce:
1. emerge =dev-games/physfs-2.0.2-r1
Actual Results:  
PhysicsFS will build with the following options:
...
-- 7zip support: disabled

Expected Results:  
PhysicsFS will build with the following options:
...
-- 7zip support: enabled
Comment 1 Peter Ebden 2012-01-07 19:48:22 UTC
Created attachment 298257 [details, diff]
patch to add optional lzma support

I've observed the same problem here. It looks to me like it's been deliberately disabled, possibly with the intention of eventually using a system library for it instead?

I suggest the attached patch, which fixes the issue for me. It's controlled by the lzma use flag, like the other compressors. I worry slightly that there was a reason for disabling it in the first place, but nothing seems to have gone wrong here yet :)
Comment 2 Oleg 2016-12-24 09:20:38 UTC
Current version =dev-games/physfs-2.0.3-r1 still has 7zip disabled.
Comment 3 Larry the Git Cow gentoo-dev 2018-03-25 19:51:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9fa283b13aa8846ede5af588ae3aebe2154c7c05

commit 9fa283b13aa8846ede5af588ae3aebe2154c7c05
Author:     Azamat H. Hackimov <azamat.hackimov@gmail.com>
AuthorDate: 2018-03-21 11:55:26 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2018-03-25 19:51:36 +0000

    dev-games/physfs: added new USE-flags
    
    Added 7zip (Bug #381973), iso, vdf, slb file formats support, cleanup for
    outdated code (Bug #649456).
    
    Closes: https://bugs.gentoo.org/381973
    Closes: https://bugs.gentoo.org/649456
    
    Package-Manager: Portage-2.3.24, Repoman-2.3.6
    Closes: https://github.com/gentoo/gentoo/pull/7532

 dev-games/physfs/metadata.xml           |  4 +++
 dev-games/physfs/physfs-3.0.1-r1.ebuild | 50 +++++++++++++++++++++++++++++++++
 dev-games/physfs/physfs-9999.ebuild     | 35 +++++++++++++----------
 3 files changed, 74 insertions(+), 15 deletions(-)