Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 381333 - x11-terms/rxvt-unicode feature request (disable underline and cursor behaviour)
Summary: x11-terms/rxvt-unicode feature request (disable underline and cursor behaviour)
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal enhancement (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: NeedPatch
Depends on:
Blocks:
 
Reported: 2011-08-31 17:17 UTC by ac.serbanescu
Modified: 2020-12-07 17:12 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to not draw the underline if underlined text is displayed in colour. (rxvt-unicode-9.15-underline.patch,833 bytes, patch)
2012-02-26 14:30 UTC, ac.serbanescu
Details | Diff
Don't draw underline if colorUL is set (rxvt-unicode-9.15-underline.patch,515 bytes, patch)
2012-02-26 18:39 UTC, ac.serbanescu
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ac.serbanescu 2011-08-31 17:17:48 UTC
Would somebody consider adding these 3 features to rxvt-unicode through a patch?
1. disable the underline if underlined text is set to be displayed as coloured;
2. making the cursor use reverse video instead of the default foreground/background;
3. making the cursor behave like under focus even when the terminal window is not focused.

Reproducible: Always
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2011-09-03 16:49:55 UTC
Where is the patch? :)

Do the resources colorUL, underlineColor help you at all?
Comment 2 ac.serbanescu 2012-02-26 14:30:42 UTC
Created attachment 303343 [details, diff]
Patch to not draw the underline if underlined text is displayed in colour.
Comment 3 ac.serbanescu 2012-02-26 18:39:51 UTC
Created attachment 303405 [details, diff]
Don't draw underline if colorUL is set

This one is better. It still disables the underline cursor if colorUL is set, but it had poor visibility anyway.
Comment 4 Ari Malinen 2014-06-28 12:20:08 UTC
(In reply to ac.serbanescu from comment #3)
> Created attachment 303405 [details, diff] [details, diff]
> Don't draw underline if colorUL is set
> 
> This one is better. It still disables the underline cursor if colorUL is
> set, but it had poor visibility anyway.

Why dont you just do the following:
Put patch to: /etc/portage/patches/x11-terms/rxvt-unicode/nameof.patch

This step is only needed if rxvt-unicode ebuild doesnt call epatch_user() by default.
Configure portage bashrc to call epatch_user() for all ebuilds:
/etc/portage/bashrc
post_src_unpack() {
        if type epatch_user &> /dev/null ; then
                if [[ -d ${S} ]]; then
                        pushd "${S}" 2>/dev/null
                        epatch_user
                        popd 2>/dev/null
                else
                        epatch_user
                fi
        fi
}

emerge rxvt-unicode
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2014-06-28 13:19:05 UTC
(Apparently we had some `use vanilla && epatch_user' logic in there. I might even have put it there myself. I have changed the ebuild so that epatch_user is /always/ called and no one needs to work around USE=vanilla.)
Comment 6 Marek Szuba gentoo-dev 2020-12-07 17:12:11 UTC
Closing due to years of inactivity.