I'm using layman in an automated installation setup which uses a (stable) portage snapshot and a (variable) overlay. I once patched layman (1.1.1) to allow specification of a CVS branch, any chance something similar can make it into 2.0.0? It would make my setup system a bit cleaner with the patch being in the snapshot, since up till now, I have had a kind of chicken-and-egg problem, with the patched layman actually being inside the overlay... I have also added another patch, adding extra parameters to the sync process that seem to me to make sense (-P prunes empty directories, -C gets clean copies (while preserving/renaming local modifications). Thanks in advance for your feedback Reproducible: Always
Created attachment 284629 [details, diff] layman-branch.patch branch patch
Created attachment 284631 [details] layman-prune.patch prune patch
ooooh, a request with patches :D will look...
The prune patch file is actually the branch patch again. Also can you attach one of your branch overlay xml definitions. The xml has changed format as well. This is not going to be so easy to apply your patches.
Created attachment 284641 [details, diff] prune patch corrected
The XML file for this one is <overlays> <overlay type="cvs" src=":pserver:readonly:readonly@10.11.11.74:/cvsrep/sit_automation" subpath="automation/AutoDistro/Overlay" contact="xxx@yyy.zzz" status="testing" branch="testautom" name="autodistro"> <description> AutoDistro overlay </description> </overlay> </overlays>
Don't CC maintainers when you cannot assign bugs.
The prune functionality can already be done using 2.0.0's *_addopts & *_syncopts which can be configured in layman.cfg for any of the repo types. That is as long as the vcs supports that option. In this case those options would be added to all cvs commands for all overlays of that type. Unfortunately, the branch patch is not easy to add. The code is laid out much different now and that portion of code is now in source.py's OverlaySource class which is common to all the repo types. That means that branching code must work for all vcs types that support it and be ignored by those that don't. Also the xml file format has changed, the old style is still usable, but it would need to be implemented in the new style and the main overlay's list verification code (on the gentoo server) also needs updating to accept overlay definitions with the branch spec. I will work to getting this functionality in for a later release, not 2.0.0. I have 2.0.0 nearly ready for final release.
(In reply to Brian Dolbec from comment #8) > The prune functionality can already be done using 2.0.0's *_addopts & > *_syncopts which can be configured in layman.cfg for any of the repo types. > That is as long as the vcs supports that option. In this case those options > would be added to all cvs commands for all overlays of that type. > > Unfortunately, the branch patch is not easy to add. The code is laid out > much different now and that portion of code is now in source.py's > OverlaySource class which is common to all the repo types. That means that > branching code must work for all vcs types that support it and be ignored > by those that don't. Also the xml file format has changed, the old style is > still usable, but it would need to be implemented in the new style and the > main overlay's list verification code (on the gentoo server) also needs > updating to accept overlay definitions with the branch spec. > > I will work to getting this functionality in for a later release, not 2.0.0. > I have 2.0.0 nearly ready for final release. Should we close this bug on layman's next release?
CVS branch functionality available in layman-2.2.0, closing as fixed.
