Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 379633 - app-emulation/vice-2.3 - pulls in TeX to build already available documentation
Summary: app-emulation/vice-2.3 - pulls in TeX to build already available documentation
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-17 23:39 UTC by avx
Modified: 2011-10-24 04:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
vice-2.3-r1.ebuild w/ pdf USE flag (vice-2.3-r1.ebuild,2.95 KB, text/plain)
2011-10-21 02:13 UTC, Jared B.
Details
vice-2.3-notexi.patch (vice-2.3-notexi.patch,467 bytes, patch)
2011-10-21 02:13 UTC, Jared B.
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description avx 2011-08-17 23:39:06 UTC
Said package now depends on virtual/texi2dvi, but from the script needing it, it's description says:
--snip--
Program to transform most Texinfo documents to HTML
--snap--

The documenation to build is already available in the tarball, lying in doc/{html}, so we should use that instead of pulling 100mb+ of deps into the system - at least on systems where this deps aren't yet installed.

Reproducible: Always

Steps to Reproduce:
1. emerge -ptv vice
2. wonder
3. 
Actual Results:  
Tries to pull in deps for a task which isn't really needed.

Expected Results:  
Should use upstream provided docs or at least have a (USE-)flag to let the user decide.
Comment 1 Mr. Bones. (RETIRED) gentoo-dev 2011-08-23 15:09:31 UTC
it doesn't build without texi2dvi so no.
Comment 2 avx 2011-08-24 05:09:18 UTC
You are somehow kidding me, right?

--
> which texi2dvi 
/usr/bin/texi2dvi
--

--
> equery b texi2dvi
 * Searching for texi2dvi ... 
sys-apps/texinfo-4.13-r1 (/usr/bin/texi2dvi)
--

--
> emerge -ptv vice

These are the packages that would be merged, in reverse order:

Calculating dependencies... done!
[ebuild  N     ] app-emulation/vice-2.3  USE="X alsa nls xrandr -Xaw3d -dga -ethernet -ffmpeg -gif -gnome -ipv6 -jpeg -lame -memmap -oss -png -pulseaudio -readline -sdl -xv -zlib" 0 kB
[ebuild  N     ]  virtual/texi2dvi-0  0 kB
[ebuild  N     ]   dev-texlive/texlive-texinfo-2011  USE="-doc -source" 84 kB
[ebuild  N     ]    dev-texlive/texlive-genericrecommended-2011  USE="-doc -source" 211 kB
[ebuild  N     ]   virtual/latex-base-1.0  0 kB
[ebuild  N     ]    dev-texlive/texlive-fontutils-2011  USE="-doc -source" 224 kB
[ebuild  N     ]    dev-texlive/texlive-latexrecommended-2011  USE="-doc -source" 6,091 kB
[ebuild  N     ]     dev-texlive/texlive-latex-2011  USE="-doc -source" 871 kB
[ebuild  N     ]      dev-texlive/texlive-basic-2011  USE="-doc -source" 5,336 kB
[ebuild  N     ]       dev-texlive/texlive-documentation-base-2011  USE="-source" 1,432 kB
[ebuild  N     ]        app-text/texlive-core-2011-r4  USE="X -cjk -doc -source -tk -xetex" 129,042 kB
[ebuild  N     ]         dev-tex/bibtexu-3.71_p20110705  0 kB
[ebuild  N     ]         app-text/ps2pkm-1.5_p20110705  0 kB
[ebuild  N     ]         app-text/dvipsk-5.991_p20110705  USE="-doc -source" 92 kB
[ebuild  N     ]         dev-tex/luatex-0.70.1  USE="-doc" 9,014 kB
[ebuild  N     ]          dev-libs/zziplib-0.13.60-r1  USE="-doc -sdl -static-libs -test" 670 kB
[ebuild  N     ]          dev-libs/kpathsea-6.0.1_p20110705  USE="-doc -source -static-libs" 41 kB

Total: 17 packages (17 new), Size of downloads: 153,102 kB
--

According to `equery d texinfo`, it is required by none other thant gcc, autoconf, automake, groff and ed. So anyone even trying to build vice via gcc will already have texi2dvi on the system.

I tried building vice by hand with the defaults, except prefix, and it worked without any problems.

So either the ebuild for vice or virtual/texi2dvi is broken.
Comment 3 Mr. Bones. (RETIRED) gentoo-dev 2011-08-24 07:33:10 UTC
It fails to build here without virtual/texi2dvi.
Comment 4 avx 2011-08-24 09:57:19 UTC
[rant]
Are you just unwilling or too lazy to care about this? Just because you may not be able to see or reproduce the problem, doesn't mean it doesn't exist, nor is it imho a valid reason to close this as WONTFIX.

I myself would like to run this on a mobile device, which is limited in diskspace and having 100+mb wasted for documentation makes no sense, when it a) is already in the tarball and b) if I take into consideration the size of this deps compared to the size of C64-games.
[/rant]

Now, to write something productive, I found that we are both right. For whatever reason, which I couldn't track down, yet, sometimes the build fails with "no TeX ...", but sometimes it just seems to ignore that and runs right through.

ie, I just ran
--snip--
tar xf vice-2.3.tar.gz
cd vice-2.3
./configure && make && echo success
--snap--

and it build without complaining. But I've also seen it fail, so somewhere there is a bug and just because it couldn't be found (by me), yet, shouldn't mean we've got to give up on this.
Comment 5 Jared B. 2011-10-21 02:11:15 UTC
This has been bothering me as well, for reasons similar to those described by avx.  I just finally got around to digging into it (since Vice 2.2 no longer compiles with libpng 1.5) and found a possible solution.

It appears that texi2dvi/texi2pdf is needed solely to generate a PDF version of the documentation (even though, as avx pointed out, this is already included... which is rather odd).  Building the PDF seems to be optional, as there's some code in the configure script that checks for texi2dvi and is supposed to disable building the PDF if it doesn't exist.  You can search for BUILD_PDF_TRUE to see this.  I'd have to assume this test is broken, because the PDF tries to get built regardless, leading to the compile failure without texi2dvi.

I couldn't really figure out what the BUILD_PDF test was even trying to do, so I worked around it by patching out the relevant code in doc/Makefile.am.  It basically forces PDF generation to be disabled, and thus removes the need for texi2dvi.  To make this optional, I've introduced a pdf USE flag.  texi2dvi is only required with USE=pdf, and conversely the patch is only applied to disable PDF generation if USE=-pdf.

I have no doubt that a more elegant solution is available for someone what a better understanding of bash and automake than I have.  Fixing the TEXT2DVI test would be the obvious contender, and simply always disabling this and just copying the included pdf would be another option.

Either way, it'd be nice if someone could review this.

avx, thanks for reporting this.  Can you please test the patch and let me know if it works for you?
Comment 6 Jared B. 2011-10-21 02:13:02 UTC
Created attachment 290399 [details]
vice-2.3-r1.ebuild w/ pdf USE flag
Comment 7 Jared B. 2011-10-21 02:13:31 UTC
Created attachment 290401 [details, diff]
vice-2.3-notexi.patch
Comment 8 Mr. Bones. (RETIRED) gentoo-dev 2011-10-24 04:13:46 UTC
in portage.  thanks for the bug report and patch.