This is a zero day stabilization for minitube-1.5. Youtube API changed again, therefore old versions do not work anymore. Please me sure you actually launch the application and play a youtube video. Thanks Thanks in advanced
amd64: pass.
amd64 ok
Created attachment 282273 [details] permission error (In reply to comment #2) > amd64 ok Must correct myself, I did some more testing and I ran into following issue when I ran it as root, exited, rerun as user I got permission error that did not allowed me to view videos.
(In reply to comment #3) > Created attachment 282273 [details] > permission error > > (In reply to comment #2) > > amd64 ok > > Must correct myself, I did some more testing and I ran into following issue > when I ran it as root, exited, rerun as user I got permission error that did > not allowed me to view videos. You are not supposed to run it as root
(In reply to comment #4) > (In reply to comment #3) > > Created attachment 282273 [details] > > permission error > > > > (In reply to comment #2) > > > amd64 ok > > > > Must correct myself, I did some more testing and I ran into following issue > > when I ran it as root, exited, rerun as user I got permission error that did > > not allowed me to view videos. > > You are not supposed to run it as root Same problem when I run it as different user, ppl are not supposed to have multiuser machines either? One way or another, its a bug (it should clean temp files on exit or create uniqe ones for every user).
(In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > Created attachment 282273 [details] > > > permission error > > > > > > (In reply to comment #2) > > > > amd64 ok > > > > > > Must correct myself, I did some more testing and I ran into following issue > > > when I ran it as root, exited, rerun as user I got permission error that did > > > not allowed me to view videos. > > > > You are not supposed to run it as root > > Same problem when I run it as different user, ppl are not supposed to have > multiuser machines either? > One way or another, its a bug (it should clean temp files on exit or create > uniqe ones for every user). Does the current stable has the same behavior?
@Flavio, could you see if this bug is valid and provide a patch if possible?
amd64: emerged it, ran a youtube video a little, rab from a chroot su -user $ firefox browsed to youtube ran a video in embedded. I'm not even sure how or why you'd run a browser as root? Likely needs a stable host boot.
Your comments about firefox are not relevant to this bug. Please pay attention on what we actually test here
(In reply to comment #7) > @Flavio, could you see if this bug is valid and provide a patch if possible? Can't confirm this in older versions, because problematic tmp file "/tmp/minitube-.mp4" is not being created in 1.4. Simple shellscript should fix this, I'll write it when im at home and post it.
Created attachment 282289 [details, diff] permission prob fix this patch should fix permission problem (needs testing)
after establishing that we don't know it all, invoked minitube, no issue with root or user permissions. It displayed a video list, then could not play them. any selection lead to cannot get video info.
(In reply to comment #11) > Created attachment 282289 [details, diff] > permission prob fix > > this patch should fix permission problem (needs testing) This can be a possible security issue, since the filename is static. An attacker can create a malicious /tmp/minitube-1.5-{$user,} file and make minitube crash
x86 stable
I modified the patch to append a random number at the end. I already sent it for review. Also marked stable for amd64 (I hope the fix wont introduce regressions)
