377757 – sys-fs/iprutils should respect CFLAGS, LDFLAGS, CC, ChangeLog does not exist

Bug 377757 - sys-fs/iprutils should respect CFLAGS, LDFLAGS, CC, ChangeLog does not exist

Summary: sys-fs/iprutils should respect CFLAGS, LDFLAGS, CC, ChangeLog does not exist

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal QA (vote)
Assignee:	ppc64 architecture team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	tc-directly ldflags
	Show dependency tree

Reported:	2011-08-04 15:41 UTC by Jeroen Roovers (RETIRED)
Modified:	2014-12-25 13:02 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
build.log (20110804-153711.log,4.42 KB, text/plain) 2011-08-04 15:41 UTC, Jeroen Roovers (RETIRED)	Details
Patch to iprutils-2.3.9.ebuild (iprutils.diff,1.11 KB, text/plain) 2012-11-12 20:28 UTC, Dane Smith (RETIRED)	Details
Patch for Makefile (iprutils-toolchain.patch,1.90 KB, text/plain) 2012-11-12 20:29 UTC, Dane Smith (RETIRED)	Details
iprutils-2.3.18.ebuild (iprutils-2.3.18.ebuild,1.20 KB, text/plain) 2014-12-23 14:41 UTC, Sergey Popov	Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jeroen Roovers (RETIRED) gentoo-dev

2011-08-04 15:41:05 UTC

Created attachment 282069 [details]
build.log

gcc -g -Wall -DIPR_MAJOR_RELEASE=2 -DIPR_MINOR_RELEASE=3 -DIPR_FIX_LEVEL=0 -DIPR_FIX_DATE='"(Aug 13, 2010)"' -DIPR_VERSION_STR='"2.3.0 (Aug 13, 2010)"' -DIPR_RELEASE=1 -I. -I/usr/include/ncurses -o iprconfig iprconfig.c iprlib.o -lform -lpanel -lncurses -lmenu -lsysfs
gcc -g -Wall -DIPR_MAJOR_RELEASE=2 -DIPR_MINOR_RELEASE=3 -DIPR_FIX_LEVEL=0 -DIPR_FIX_DATE='"(Aug 13, 2010)"' -DIPR_VERSION_STR='"2.3.0 (Aug 13, 2010)"' -DIPR_RELEASE=1 -I. -I/usr/include/ncurses -o iprupdate iprlib.o iprupdate.c -lsysfs

and so on. Disrespects CC, injects -g, ignores CFLAGS.


 * QA Notice: file does not exist:
 * 
 *      dodoc: ChangeLog does not exist

 * QA Notice: Files built without respecting LDFLAGS have been detected
 *  Please include the following list of files in your report:
 * /sbin/iprconfig
 * /sbin/iprdump
 * /sbin/iprinit
 * /sbin/iprupdate
 * /sbin/iprdbg

Comment 1 Dane Smith (RETIRED) gentoo-dev

2012-11-12 20:28:11 UTC

Created attachment 329376 [details]
Patch to iprutils-2.3.9.ebuild

Patch. Bump to EAPI 4. Drop useless ebeep. Make use of patch to Makefile to deal with lack of toolchain respect.

Comment 2 Dane Smith (RETIRED) gentoo-dev

2012-11-12 20:29:42 UTC

Created attachment 329378 [details]
Patch for Makefile

Fixes CFLAGS, LDFLAGS, and Compiler respect.

Comment 3 Dane Smith (RETIRED) gentoo-dev

2012-11-12 20:31:20 UTC

Brent - Let me know if you have any objections to any of these changes. If I don't hear anything in a week or so I'm going to go ahead and commit them.

Comment 4 Jeroen Roovers (RETIRED) gentoo-dev

2012-11-13 01:20:24 UTC

Comment on attachment 329376 [details]
Patch to iprutils-2.3.9.ebuild

I say get rid of the einfos. :)

Comment 5 Sergey Popov gentoo-dev

2014-12-23 14:41:58 UTC

Created attachment 392276 [details]
iprutils-2.3.18.ebuild

Ebuild for version 2.3.18 with changes, based on previously suggested patches by Dane Smith

Comment 6 Sergey Popov gentoo-dev

2014-12-25 13:02:43 UTC

+*iprutils-2.3.18 (25 Dec 2014)
+
+  25 Dec 2014; Sergey Popov <pinkbyte@gentoo.org> -iprutils-2.3.0.ebuild,
+  +iprutils-2.3.18.ebuild:
+  Version bump, respect compiler, CFLAGS and LDFLAGS, wrt bug #377757. Drop old
+  version