Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 377363 (libpng-1.5-xsane) - media-gfx/xsane-0.997 (and 0.996) fail to compile against libpng-1.5
Summary: media-gfx/xsane-0.997 (and 0.996) fail to compile against libpng-1.5
Status: RESOLVED FIXED
Alias: libpng-1.5-xsane
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Graphics Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: libpng-1.5
  Show dependency tree
 
Reported: 2011-08-02 00:22 UTC by Stuart Longland (RETIRED)
Modified: 2011-08-07 16:54 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
xsane-0.996 build log (0.997 fails the same way) (build.log,39.11 KB, text/plain)
2011-08-02 00:22 UTC, Stuart Longland (RETIRED) 		Details
Updated ebuild for xsane-0.997 (xsane-0.997.ebuild,1.98 KB, text/plain)
2011-08-02 04:41 UTC, Stuart Longland (RETIRED) 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stuart Longland (RETIRED) gentoo-dev 2011-08-02 00:22:52 UTC 
Created attachment 281789 [details]
xsane-0.996 build log (0.997 fails the same way)

xsane fails to build against libpng-1.5, as it tries to access the jmpbuf member of the png_info struct.

The fix is easily patched with a simple sed one-liner in src_compile:

        ebegin "Patching ${S}/src/xsane-save.c for libpng-1.5"
        sed -i -e 's/png_ptr->jmpbuf/png_jmpbuf(png_ptr)/' \
                "${S}/src/xsane-save.c"
        eend $?

I'll attach an updated ebuild shortly.  I can confirm this fix works, at least for 0.997.  Should work for 0.996 too.
Comment 1 Stuart Longland (RETIRED) gentoo-dev 2011-08-02 04:41:12 UTC 
Created attachment 281795 [details]
Updated ebuild for xsane-0.997
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2011-08-07 16:54:18 UTC 
added to 0.998