Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 374709 - sci-physics/root-5.32.00 version bump
Summary: sci-physics/root-5.32.00 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Science Physics related packages
URL: http://root.cern.ch/drupal/content/pr...
Whiteboard:
Keywords: InOverlay
: 384729 (view as bug list)
Depends on: 393071
Blocks:
  Show dependency tree
 
Reported: 2011-07-10 14:21 UTC by Andrew Savchenko
Modified: 2012-01-21 19:41 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
root-5.30.00-xrootd-prop-flags.patch (root-5.30.00-xrootd-prop-flags.patch,31.81 KB, patch)
2011-07-10 14:23 UTC, Andrew Savchenko
Details | Diff
root-5.30.00-nobyte-compile.patch (root-5.30.00-nobyte-compile.patch,5.40 KB, patch)
2011-07-10 14:24 UTC, Andrew Savchenko
Details | Diff
root-5.30.00-lzma.patch (root-5.30.00-lzma.patch,533 bytes, patch)
2011-07-10 14:27 UTC, Andrew Savchenko
Details | Diff
root-5.30.00.ebuild (root-5.30.00.ebuild,9.89 KB, text/plain)
2011-07-10 14:28 UTC, Andrew Savchenko
Details
root-5.30.00-afs.patch (root-5.30.00-afs.patch,529 bytes, patch)
2011-07-10 14:38 UTC, Andrew Savchenko
Details | Diff
root-5.30.00.ebuild-00docs.patch (root-5.30.00.ebuild-00docs.patch,441 bytes, patch)
2011-07-10 14:59 UTC, Andrew Savchenko
Details | Diff
root-5.30.00.ebuild-01patchset.patch (root-5.30.00.ebuild-01patchset.patch,1007 bytes, patch)
2011-07-10 14:59 UTC, Andrew Savchenko
Details | Diff
root-5.30.00.ebuild-02lzma.patch (root-5.30.00.ebuild-02lzma.patch,1.28 KB, patch)
2011-07-10 15:00 UTC, Andrew Savchenko
Details | Diff
root-5.30.00.ebuild-03libs.patch (root-5.30.00.ebuild-03libs.patch,423 bytes, patch)
2011-07-10 15:01 UTC, Andrew Savchenko
Details | Diff
root-5.30.00.ebuild-04xft.patch (root-5.30.00.ebuild-04xft.patch,496 bytes, patch)
2011-07-10 15:03 UTC, Andrew Savchenko
Details | Diff
root-5.30.00.ebuild-05optional-X.patch (root-5.30.00.ebuild-05optional-X.patch,2.37 KB, patch)
2011-07-10 15:06 UTC, Andrew Savchenko
Details | Diff
Patches configure script to correctly link root against the dynamic cfitsio library. (root-5.32.00-cfitsio.patch,593 bytes, patch)
2012-01-19 22:28 UTC, Marcel Straub
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Savchenko gentoo-dev 2011-07-10 14:21:36 UTC
Hello,

production release 5.30.00 was issued quite a while ago.

Aside from updated patchset I made some changes to the ebuild:
- lzma support (for root file data compression);
- X support is now optional (but enabled by default, of course), this is extremely useful on X-less computating stations; tested on ~amd64;
- fix tmva and roofit documentation installation (pdfs were missed due to ebuild typo;
- some small fixes.

In patchset all patches are still required, nobyte-compile and xrootd-prop-flags patches were updated, new lzma patch is present (it is required to compile with system xz-utils).

Despite root now support cmake alongside with traditional configure, I do not think it is time now to switch to cmake: configure script is not deprecated now and I personally prefer plain configure over cumbersome cmake configs.
Comment 1 Andrew Savchenko gentoo-dev 2011-07-10 14:23:42 UTC
Created attachment 279619 [details, diff]
root-5.30.00-xrootd-prop-flags.patch

Updated from old patchset.
Comment 2 Andrew Savchenko gentoo-dev 2011-07-10 14:24:42 UTC
Created attachment 279621 [details, diff]
root-5.30.00-nobyte-compile.patch

Updated patch.
Comment 3 Andrew Savchenko gentoo-dev 2011-07-10 14:27:18 UTC
Created attachment 279625 [details, diff]
root-5.30.00-lzma.patch

This patch is required to build with system xz-utils.
Otherwise build fails as follows:

In file included from /var/tmp/portage/sci-physics/root-5.30.00/work/root/core/lzma/src/ZipLZMA.c:13:0:                                        
/usr/include/lzma/lzma.h:16:3: error: #error Never include this file directly. Use <lzma.h> instead.

The problem occurs, because /usr/include/lzma/ directory is search for lzma.h before /usr/include/.
Comment 4 Andrew Savchenko gentoo-dev 2011-07-10 14:28:42 UTC
Created attachment 279627 [details]
root-5.30.00.ebuild

Updated ebuild, will split it into separate patches for different changes in a while.
Comment 5 Andrew Savchenko gentoo-dev 2011-07-10 14:38:42 UTC
Created attachment 279631 [details, diff]
root-5.30.00-afs.patch

Unfortunately, root still fails to build with afs support using openafs-1.6.0_pre3.

The first problem is type cast error, which could be easily fixed as in this patch; but then API change problems arose. They can't be trivially fixed, so I can do nothing with this ATM.

And I can't use older 1.4.x openafs, because it fails to build with 2.6.38 kernel and above.

This patch is not included in the patchset, because in doesn't fix the problem completely.
Comment 6 Andrew Savchenko gentoo-dev 2011-07-10 14:59:17 UTC
Created attachment 279633 [details, diff]
root-5.30.00.ebuild-00docs.patch

Fix TMVA and RooFit pdf installation.
Comment 7 Andrew Savchenko gentoo-dev 2011-07-10 14:59:49 UTC
Created attachment 279635 [details, diff]
root-5.30.00.ebuild-01patchset.patch

Apply new patches.
Comment 8 Andrew Savchenko gentoo-dev 2011-07-10 15:00:37 UTC
Created attachment 279637 [details, diff]
root-5.30.00.ebuild-02lzma.patch

Adds system lzma support using xz-utils, applies lzma patch.
Comment 9 Andrew Savchenko gentoo-dev 2011-07-10 15:01:12 UTC
Created attachment 279639 [details, diff]
root-5.30.00.ebuild-03libs.patch

Adds some missed deps.
Comment 10 Andrew Savchenko gentoo-dev 2011-07-10 15:03:31 UTC
Created attachment 279641 [details, diff]
root-5.30.00.ebuild-04xft.patch

Makes libXft dependency controlled by xft flag.

With USE="xft":
ldd /usr/lib/root/*.so | grep -i xft -B 10                                                                                                     
        libpcre.so.0 => /lib/libpcre.so.0 (0xb65e0000)                                                                                         
        /lib/ld-linux.so.2 (0xb77f1000)                                                                                                        
        libXau.so.6 => /usr/lib/libXau.so.6 (0xb65dc000)                                                                                       
        libXdmcp.so.6 => /usr/lib/libXdmcp.so.6 (0xb65d5000)                                                                                   
/usr/lib/root/libGX11TTF.so:                                                                                                                   
        linux-gate.so.1 =>  (0xb7706000)                                                                                                       
        libfreetype.so.6 => /usr/lib/libfreetype.so.6 (0xb7629000)                                                                             
        libGX11.so.5.30 => /usr/lib/root/libGX11.so.5.30 (0xb75de000)                                                                          
        libGraf.so.5.30 => /usr/lib/root/libGraf.so.5.30 (0xb744b000)                                                                          
        libX11.so.6 => /usr/lib/libX11.so.6 (0xb7328000)                                                                                       
        libXft.so.2 => /usr/lib/libXft.so.2 (0xb7313000)       

With USE="-xft":
$ ldd /usr/lib/root/*.so | grep -i xft -B 10

Binaries doesn't depend on libXft either way.
Comment 11 Andrew Savchenko gentoo-dev 2011-07-10 15:06:34 UTC
Created attachment 279643 [details, diff]
root-5.30.00.ebuild-05optional-X.patch

This one make X support optional. Of course, it is enabled by default.

But even without X11 support root can build and works well for data processing (tested on ~amd64). Of course, it is impossible to save canvas as a picture in this setup, but it is sufficient for pure data processing.
Comment 12 Andrew Savchenko gentoo-dev 2011-07-10 15:07:29 UTC
Well, that's all.
At this moment new root works well, but I haven't done hard testing yet.
Comment 13 Sébastien Fabbro (RETIRED) gentoo-dev 2011-07-25 17:15:07 UTC
Hi Andrew,

Thanks for all the patches. Would you consider getting commit access to the science overlay so we can have smoother updates to the root ebuilds?

I am working on splitting xrootd as well.
Comment 14 Andrew Savchenko gentoo-dev 2011-07-27 19:31:45 UTC
Hello,

(In reply to comment #13)
> Thanks for all the patches. Would you consider getting commit access to the
> science overlay so we can have smoother updates to the root ebuilds?

It sounds like a good idea.
Comment 15 Andrew Savchenko gentoo-dev 2011-08-02 22:12:03 UTC
I pushed changes into science overlay.
Comment 16 Justin Lecher (RETIRED) gentoo-dev 2011-11-16 10:23:24 UTC
What is state of progress here?
Comment 17 Justin Lecher (RETIRED) gentoo-dev 2011-11-16 10:23:33 UTC
*** Bug 384729 has been marked as a duplicate of this bug. ***
Comment 18 Andrew Savchenko gentoo-dev 2011-11-16 10:32:18 UTC
(In reply to comment #16)
> What is state of progress here?

ATM you may use root-5.30.03-r1 from science overlay.
5.30.04 is released already, but I have some problems with it, so until I'll figure them out I'll not put it into the overlay.
Comment 19 Andrew Savchenko gentoo-dev 2011-12-04 00:40:36 UTC
Hello,

some news: ROOT v5.32.00 was released. I updated ebuilds in the science overlay. 
Major changes are:

1) xrootd is now unbundled upstream, I created a separate package sci-physics/xrootd in the science overlay. It was tested on ~x86 and ~amd64 to build and run on some basic setup with some USE flags combinations, including all flags enabled and all flags disabled.

2) It is now possible to build root-5.32.00 with openafs-1.6.0 support if openafs is patched with the patch from bug 393071. The problem is that afs hides some symbols in shared libraries which are present in the same static libraries (usually one expects them to provide the same list of symbols). 

Also there is an afs patch which is applied to the root ebuild, it:
- fixes type cast;
- defines root strlcpy, strlcat symbols as weak, because they are redefined in openafs.
Comment 20 Marcel Straub 2012-01-19 22:27:02 UTC
Hi,

I tried to compile sci-physics/root-5.32.00-r1 from the science overlay with fitsio (USER="fits"). However, this caused a problem with the root configure script which tried to dynamically link against the statical version of the sci-libs/cfitsio library. 

I fixed this problem by patching the configure script with the attached root-5.32.00-cfitsio.patch and applying it while src_prepare().
Comment 21 Marcel Straub 2012-01-19 22:28:11 UTC
Created attachment 299341 [details, diff]
Patches configure script to correctly link root against the dynamic cfitsio library.
Comment 22 Andrew Savchenko gentoo-dev 2012-01-20 09:15:58 UTC
Fixed in root-5.32.00-r2 (science overlay).

Good catch, thanks for the patch. I use cfitsio built without static-libs, so I missed this problem before.
Comment 23 Sébastien Fabbro (RETIRED) gentoo-dev 2012-01-21 19:41:50 UTC
Now in the main tree. Thanks!