Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 372915 - sys-auth/rtkit should use systemd.eclass to install systemd units
Summary: sys-auth/rtkit should use systemd.eclass to install systemd units
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Arun Raghavan (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: systemd-consumers
  Show dependency tree
 
Reported: 2011-06-24 21:39 UTC by Christoph Brill (egore) (RESIGNED)
Modified: 2011-09-15 19:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
rtkit-systemd.patch (rtkit-systemd.patch,487 bytes, patch)
2011-06-25 08:33 UTC, Christoph Brill (egore) (RESIGNED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Brill (egore) (RESIGNED) 2011-06-24 21:39:03 UTC
Upstream does supply a set of systemd unit files in the distribution tarball
and an ability to control installation of those files through the
--with/--without-systemdsystemunitdir option. The ebuild is currently unaware
of these options, making installation of systemd units pkgconfig file dependant
and thus automagic.

The ebuild shall use systemd.eclass to handle installation of the systemd unit
files in a clean and unified way.

The preferred way to handle that is to use autotools-utils eclass, and call
`systemd_to_myeconfargs' before `autotools-utils_src_configure', as in:

    inherit autotools-utils systemd

    src_configure() {
        local myeconfargs=(
            $(use_enable foo)
            --with-bar
        )

        systemd_to_myeconfargs
        autotools-utils_src_configure
    }

If you're not interested in migrating to autotools-utils, there is also a
legacy `systemd_with_unitdir' function, which could be used like that:

    inherit systemd

    src_configure() {
        econf \
            $(use_enable foo) \
            --with-bar \
            "$(systemd_with_unitdir)"
    }

Currently introduction of the eclass will cause the package to install systemd
unit files unconditionally. If you don't like that concept, feel free to take a
vote on the appropriate gentoo-dev ml topic. The eclass behaviour might change
in future.

Reproducible: Always
Comment 1 Christoph Brill (egore) (RESIGNED) 2011-06-25 08:33:11 UTC
Created attachment 278083 [details, diff]
rtkit-systemd.patch

This patch adds the necessary support to the ebuild.
Comment 2 Arun Raghavan (RETIRED) gentoo-dev 2011-09-15 19:47:43 UTC
Sorry about the inordinate delay, and thanks for the patch. This is in CVS with the 0.10 bump now.