Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 371635 - app-portage/getdelta picks bad source file names
Summary: app-portage/getdelta picks bad source file names
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Patrick Lauer
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-14 16:39 UTC by Xake
Modified: 2018-07-02 19:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xake 2011-06-14 16:39:06 UTC
So...
I have app-portage/getdelta-0.7.8 installed with the patch applied to make it work with EAPI=2 and higher.

But...

Somehow getdelta thinks it is fun to download a file bigger then what is manifested...

>>> Fetching (69 of 1230) sys-devel/bin86-0.16.18
>>> Downloading 'http://distfiles.gentoo.org/distfiles/bin86-0.16.18.tar.gz'
Searching for a previously downloaded file in /var/portage/distfiles

We have the following candidates to choose from 
bind-9.7.3.tar.gz 

The best of all is ... bind-9.7.3.tar.gz

Checking if this file is OK.

Trying to download bind-9.7.3.tar.gz-bin86-0.16.18.tar.gz.dtu

--2011-06-14 17:58:46--  http://linux01.gwdg.de/~nlissne/deltup.php?have=bind-9.7.3.tar.gz&want=bin86-0.16.18.tar.gz&url=http://www.debath.co.uk/dev86/bin86-0.16.18.tar.gz&version=0.7&time=1308067126
Resolving linux01.gwdg.de (linux01.gwdg.de)... 134.76.13.21
Connecting to linux01.gwdg.de (linux01.gwdg.de)|134.76.13.21|:80... connected.
HTTP request sent, awaiting response... 302 Moved Temporarily
Location: http://91.191.147.227:81/bind-9.7.3.tar.gz-bin86-0.16.18.tar.gz.dtu [following]
--2011-06-14 17:58:47--  http://91.191.147.227:81/bind-9.7.3.tar.gz-bin86-0.16.18.tar.gz.dtu
Connecting to 91.191.147.227:81... connected.
HTTP request sent, awaiting response... 200 OK
Length: 276024 (270K) [application/octet-stream]
Saving to: `bind-9.7.3.tar.gz-bin86-0.16.18.tar.gz.dtu'

68% [======================================================================================================================================================================================================>                                                                                           ] 189,889     5.89K/s  eta 17s     ^

However:
 emerge -pv bin86

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild   R    ] sys-devel/bin86-0.16.18  143 kB

Total: 1 package (1 reinstall), Size of downloads: 143 kB



So I guess this is really two bugs:
first is that getdelta.sh should be better att figuring out what a good candidate for a bin-delta may be.
second is that getdelta should query the server to see if the delta is acctually smaller then the original download.

I think first could be easily implemented fetching ${P} (and maybe check for ${MY_P}) from the environment and compare it to ${FILE}, and if it is a match, us it to figure out what is a comparable match found in ${DISTDIR}.
Second one coulöd be harder as you may not be able to trust the info from the server, and you must have one way to look up the metadata for the ebuild in question to make sure that the dtu acctually is smaller.
Comment 1 Pavel Kozlov 2018-07-02 19:36:05 UTC
Hello! Is getdelta still supported by gentoo? When I try to use it, I see response from linux01.dwdg.de "Your request has been queued (Pos. 21154)", and that's it, no delta, next thing wget just downloads the full size file.