Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 368783 - net-libs/opal-3.6.8-r2 x264 plugin fails to compile
Summary: net-libs/opal-3.6.8-r2 x264 plugin fails to compile
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: voip herd (OBSOLETE)
URL:
Whiteboard:
Keywords:
: 305803 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-05-26 09:53 UTC by Zsolti
Modified: 2012-10-24 14:30 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge_info_proto1.txt,5.19 KB, text/plain)
2011-05-26 09:54 UTC, Zsolti
Details
Updated ebuild to compile with newer ffmpeg versions (opal-3.6.8-r3.ebuild,8.26 KB, text/plain)
2011-05-28 11:26 UTC, Zsolti
Details
Changes config system to prevent failing h264_decoder_check (opal-h264_config_fix.patch,5.43 KB, patch)
2011-05-28 11:27 UTC, Zsolti
Details | Diff
Prevents compilation failure of h264 codec with newer ffmpeg (opal-h264_build_fix.patch,1.32 KB, patch)
2011-05-28 11:28 UTC, Zsolti
Details | Diff
Adding some params to h264 encoder (opal-h264_params.patch,932 bytes, patch)
2011-05-28 11:30 UTC, Zsolti
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zsolti 2011-05-26 09:53:19 UTC
The wrong commandline option in configure:
cc1: warning: command line option "-fno-visibility-inlines-hidden" is valid for C++/ObjC++ but not for C
In the check for compiling the x264 plugin prevents it to be built

Reproducible: Always

Actual Results:  
x264 codec wont be built. x264 dont shows up in ekiga.
Comment 1 Zsolti 2011-05-26 09:54:37 UTC
Created attachment 274689 [details]
emerge --info
Comment 2 Rafał Mużyło 2011-05-26 16:12:13 UTC
That's just a warning - attach full build log.
Comment 3 Zsolti 2011-05-26 21:14:24 UTC
(In reply to comment #2)
> That's just a warning - attach full build log.

Hi,
I think even the warning let the test fail. But that's not all. Later on a test for h264_decoder fails because libavcodec can't be linked. I think a patch for the config system is needed like this: https://build.opensuse.org/package/view_file?file=opal-config-fix.patch&package=opal&project=home%3Akommerck&srcmd5=bc19cf661e549f9612b669a769587e56
I just checked with newest "unstable" ffmpeg 0.7_rc1. Maybe the test works with older ffmpeg versions.
I can't send you a build log right now because I'm trying out the suse patch.
Comment 4 Zsolti 2011-05-28 11:25:12 UTC
you were right the warning doesn't let the compilation fail. later on the check for h264_decoder does.
i attached an updated ebuild which fixes this issue along with the required patches. i tested it with the ekiga echo service only. according to this h264 plugin is built and used by ekiga.
patches from:
https://bugzilla.gnome.org/show_bug.cgi?id=596006
https://build.opensuse.org/package/files?package=opal&project=home%3Akommerck&rev=bc19cf661e549f9612b669a769587e56
Comment 5 Zsolti 2011-05-28 11:26:37 UTC
Created attachment 274879 [details]
Updated ebuild to compile with newer ffmpeg versions
Comment 6 Zsolti 2011-05-28 11:27:43 UTC
Created attachment 274881 [details, diff]
Changes config system to prevent failing h264_decoder_check
Comment 7 Zsolti 2011-05-28 11:28:51 UTC
Created attachment 274883 [details, diff]
Prevents compilation failure of h264 codec with newer ffmpeg
Comment 8 Zsolti 2011-05-28 11:30:43 UTC
Created attachment 274885 [details, diff]
Adding some params to h264 encoder
Comment 9 Peter Volkov (RETIRED) gentoo-dev 2011-06-01 15:19:55 UTC
*** Bug 305803 has been marked as a duplicate of this bug. ***
Comment 10 Carl Michal 2011-06-13 16:13:44 UTC
Patches work for me.  They solve the problem of ekiga not being able to load the x264 plugin - but that only works if the x264-static use flag is enabled for opal.
Comment 11 Jesus Rivero (RETIRED) gentoo-dev 2012-10-24 14:30:28 UTC
New version on the tree should fix this:

23 Oct 2012; Jesus Rivero <neurogeek@gentoo.org> opal-3.6.8-r2.ebuild,
+opal-3.10.8.ebuild, +files/opal-3.10.8-disable-h323-workaround.patch,
+files/opal-3.10.8-labs_is_in_stdlib.patch,
+files/opal-3.10.8-svn_revision_override.patch, metadata.xml:
Version bump, fixing several bugs. Adjusted opal-3.6.8 dep on ptlib <
2.10.8. Added myself as maintainer

Please REOPEN if the issues persist.