Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 367937 - sys-fs/cryptsetup - dm-crypt-start.sh should not contain bashisms
Summary: sys-fs/cryptsetup - dm-crypt-start.sh should not contain bashisms
Status: RESOLVED DUPLICATE of bug 255528
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-18 17:21 UTC by Petr Šabata
Modified: 2011-05-28 15:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Change the C-style for loop to a while loop (0001-dm-crypt-start.sh-shouldn-t-contain-bashisms.patch,1.21 KB, patch)
2011-05-18 17:22 UTC, Petr Šabata 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Šabata 2011-05-18 17:21:46 UTC 
All shell scripts should be POSIX compatible, not depending on a
specific shell implementation without explicitly stating so.

dm-crypt-start.sh uses a C-style for loop on lines 153-160

Reproducible: Always

Steps to Reproduce:
1. Look in the file.
Actual Results:  
A bashism is present.

Expected Results:  
No bashisms present.

cryptsetup-1.2.0-r1
Comment 1 Petr Šabata 2011-05-18 17:22:48 UTC 
Created attachment 273849 [details, diff]
Change the C-style for loop to a while loop
Comment 2 Petr Šabata 2011-05-19 19:33:48 UTC 
Comment on attachment 273849 [details, diff]
Change the C-style for loop to a while loop

There are many, many more things to fix...
Comment 3 SpanKY gentoo-dev 2011-05-28 15:32:33 UTC 

*** This bug has been marked as a duplicate of bug 255528 ***