Bug 367815 – >sys-process/acct-6.5.5: initscript not completely openrc compatible

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Robert Trace 2011-05-17 20:52:44 UTC]

Initscript uses svc_(start|stop).  These functions don't appear to be supported in openrc.


Reproducible: Always

[Comment 1 Robert Trace 2011-05-17 20:53:53 UTC]

Created attachment 273715 [details, diff]
Remove svc_(start|stop) and make openrc compatible

[Comment 2 William Hubbs 2011-05-17 23:05:16 UTC]

(In reply to comment #1)
> Created attachment 273715 [details, diff]
> Remove svc_(start|stop) and make openrc compatible

This patch is not quite correct.

openrc has a command, rc-service. It should be used to stop/start services.

rc-service foo stop
or
rc-service foo start

will stop or start service foo.

[Comment 3 Robert Trace 2011-05-17 23:20:10 UTC]

(In reply to comment #2)
> 
> This patch is not quite correct.

Ok, I'll fix it up.  I couldn't find much documentation about what services/commands were available or any best practices, so I just guessed based on what some other initscript was doing.

I'll fix this patch as per your suggestion and I'll hunt down that other script and patch it too.

[Comment 4 Robert Trace 2011-05-18 01:17:42 UTC]

Created attachment 273767 [details, diff]
acct.initd.patch

Updated patch to reflect William's comments.  Fix and invert the logic a bit.

[Comment 5 SpanKY 2011-10-20 05:07:43 UTC]

should be all set now in the tree.  thanks for the report!

http://sources.gentoo.org/sys-process/acct/files/acct.initd?r1=1.2&r2=1.3