Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 366531 - net-voip/telepathy-salut-0.5.0 needs a build-time dependency on app-text/xmldiff
Summary: net-voip/telepathy-salut-0.5.0 needs a build-time dependency on app-text/xmldiff
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: Inclusion
Depends on:
Blocks:
 
Reported: 2011-05-09 04:29 UTC by Alexandre Rostovtsev (RETIRED)
Modified: 2011-06-19 11:47 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild that skips xmldiff configure check when FEATURES=-test (telepathy-salut-0.5.0.ebuild,1.32 KB, text/plain)
2011-05-15 08:32 UTC, Alexandre Rostovtsev (RETIRED)
Details
xmldiff-warn.patch (xmldiff-warn.patch,374 bytes, patch)
2011-05-28 20:50 UTC, Ed Catmur
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-05-09 04:29:21 UTC
net-voip/telepathy-salut-0.5.0 fails to configure if it cannot find xmldiff:

# emerge telepathy-salut
[...]
checking to see if compiler understands -Werror... yes
checking to see if compiler understands -Wno-missing-field-initializers... yes
checking to see if compiler understands -Wno-error=missing-field-initializers... yes
checking to see if compiler understands -Wno-unused-parameter... yes
checking to see if compiler understands -Wno-error=unused-parameter... yes
checking for xsltproc... xsltproc
checking for xmldiff... no
configure: error: xmldiff is required for the gibber tests

!!! Please attach the following file when seeking support:
!!! /var/tmp/portage/net-voip/telepathy-salut-0.5.0/work/telepathy-salut-0.5.0/config.log
 * ERROR: net-voip/telepathy-salut-0.5.0 failed (configure phase):
 *   econf failed

With app-text/xmldiff-0.6.10 installed, telepathy-salut-0.5.0 emerges correctly. So app-text/xmldiff needs to be added to DEPEND of the telepathy-salut-0.5.0 ebuild.
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2011-05-09 06:48:09 UTC
I thought this was only for tests. I'll fix it asap.
Comment 2 Pacho Ramos gentoo-dev 2011-05-09 09:22:39 UTC
(In reply to comment #1)
> I thought this was only for tests. I'll fix it asap.

Will you fix it simply adding the xmldiff dep unconditionally? Looks like it should only be needed for tests :-/ (or configure output is wrong)
Comment 3 PhobosK 2011-05-10 19:26:13 UTC
My "test" flag is not set, and configure fails...
So an unconditional dep is needed...
Comment 4 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-05-15 08:32:18 UTC
Created attachment 273245 [details]
ebuild that skips xmldiff configure check when FEATURES=-test

(In reply to comment #2)
> (In reply to comment #1)
> > I thought this was only for tests. I'll fix it asap.
> 
> Will you fix it simply adding the xmldiff dep unconditionally? Looks like it
> should only be needed for tests :-/ (or configure output is wrong)

You are correct, it's only needed for tests, but configure is checking for it unconditionally due to upstream silliness (see NEWS). Fortunately, autoconf provides an easy way to bypass the AC_CHECK_PROGS check: simply have ac_cv_prog_XMLDIFF point to some working executable.

The attached ebuild sets ac_cv_prog_XMLDIFF=/bin/true in src_configure() when FEATURES=-test. I have verified that it builds correctly without xmldiff installed.
Comment 5 Arc Riley 2011-05-18 23:34:36 UTC
I had the same issue, configure fails without xmldiff, compiles fine after its added.
Comment 6 Priit Laes (IRC: plaes) 2011-05-25 02:42:50 UTC
Well, in case someone happens to commit the fix, there's also following QA issue:

 * 	configure: WARNING: unrecognized options: --disable-plugins
Comment 7 Gilles Dartiguelongue (RETIRED) gentoo-dev 2011-05-25 16:27:13 UTC
The QA warning can't be fixed as it comes from another autotools configure triggered by the toplevel one for a lib that might be split in the future.
Comment 8 Ed Catmur 2011-05-28 20:50:38 UTC
Created attachment 274943 [details, diff]
xmldiff-warn.patch

Downgrade xmldiff error to a warning.  I prefer this patch as it seems less magical.
Comment 9 Pacho Ramos gentoo-dev 2011-06-19 11:47:25 UTC
  07 Jun 2011; Olivier Crête <tester@gentoo.org> telepathy-salut-0.5.0.ebuild:
  xmldiff is alwasy required for the configure to pass