366393 – [PATCH] sys-apps/acl-2.2.51 fails to build if /bin/sh is not bash

Bug 366393 - [PATCH] sys-apps/acl-2.2.51 fails to build if /bin/sh is not bash

Summary: [PATCH] sys-apps/acl-2.2.51 fails to build if /bin/sh is not bash

Status:	RESOLVED DUPLICATE of bug 365397

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Core system (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo's Team for Core System packages

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-05-07 19:34 UTC by Alec Moskvin
Modified:	2011-05-16 02:46 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Fix for acl-2.2.51.ebuild (acl-2.2.51-shell.patch,388 bytes, patch) 2011-05-07 19:36 UTC, Alec Moskvin	Details \| Diff
Patched ebuild (for convenience) (acl-2.2.51.ebuild,1.96 KB, text/plain) 2011-05-07 19:39 UTC, Alec Moskvin	Details
Fix for acl-2.2.51.ebuild, by passing SHELL to emake (acl-2.2.51-shell2.patch,463 bytes, patch) 2011-05-15 19:05 UTC, Alec Moskvin	Details \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alec Moskvin 2011-05-07 19:34:09 UTC

acl fails to build with /bin/sh set to a different POSIX shell.


Reproducible: Always

Steps to Reproduce:
1. set /bin/sh to point to /bin/dash
2. emerge =sys-apps/acl-2.2.51

Actual Results:  
...
gmake[2]: Entering directory `/var/tmp/portage/sys-apps/acl-2.2.51/work/acl-2.2.51/libmisc'
/bin/sh ../libtool --mode=compile x86_64-pc-linux-gnu-gcc -O2 -march=native -pipe -fno-ident -floop-interchange -floop-strip-mine -floop-block -ggdb -O2 -march=native -pipe -fno-ident -floop-interchange -floop-strip-mine -floop-block -ggdb -DNDEBUG -funsigned-char -fno-strict-aliasing -Wall -DVERSION=\"2.2.51\" -DLOCALEDIR=\"/usr/share/locale\" -DPACKAGE=\"acl\" -I./include -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64  -O2 -march=native -pipe -fno-ident -floop-interchange -floop-strip-mine -floop-block -ggdb -DNDEBUG -funsigned-char -fno-strict-aliasing -Wall -DVERSION=\"2.2.51\" -DLOCALEDIR=\"/usr/share/locale\" -DPACKAGE=\"acl\" -I./include -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64  -O2 -march=native -pipe -fno-ident -floop-interchange -floop-strip-mine -floop-block -ggdb -DNDEBUG -funsigned-char -fno-strict-aliasing -Wall -DVERSION=\"2.2.51\" -DLOCALEDIR=\"/usr/share/locale\" -DPACKAGE=\"acl\" -I../include -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64   -c quote.c
eval: 1: base_compile+= x86_64-pc-linux-gnu-gcc: not found
eval: 1: base_compile+= -O2: not found
eval: 1: base_compile+= -march=native: not found
...


Expected Results:  
/bin/sh should not be used on bash scripts.

Comment 1 Alec Moskvin 2011-05-07 19:36:23 UTC

Created attachment 272427 [details, diff]
Fix for acl-2.2.51.ebuild

This patch replaces SHELL=/bin/sh with SHELL=/bin/bash in include/buildmacros, which causes the build to complete successfully.

Comment 2 Alec Moskvin 2011-05-07 19:39:06 UTC

Created attachment 272429 [details]
Patched ebuild (for convenience)

Comment 3 Otamay 2011-05-12 07:24:50 UTC

Confirmed this and http://bugs.gentoo.org/show_bug.cgi?id=366671 on Gentoo AMD64 , patch works, too.

¡Thank you for noticing!

Comment 4 Michał Górny archtester

2011-05-15 18:07:09 UTC

Another solution is to pass SHELL=/bin/bash to emake.

Comment 5 Alec Moskvin 2011-05-15 19:05:41 UTC

Created attachment 273315 [details, diff]
Fix for acl-2.2.51.ebuild, by passing SHELL to emake

(In reply to comment #4)
> Another solution is to pass SHELL=/bin/bash to emake.

Definitely a much better solution :)

Comment 6 SpanKY gentoo-dev

2011-05-16 02:45:49 UTC

Comment on attachment 273315 [details, diff]
Fix for acl-2.2.51.ebuild, by passing SHELL to emake

this is still wrong

Comment 7 SpanKY gentoo-dev

2011-05-16 02:46:23 UTC


*** This bug has been marked as a duplicate of bug 365397 ***