Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 365809 - dev-python/pyopenssl-0.12 dodoc call is EAPI incompliant
Summary: dev-python/pyopenssl-0.12 dodoc call is EAPI incompliant
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 356389
  Show dependency tree
 
Reported: 2011-05-03 12:44 UTC by Brian Harring (RETIRED)
Modified: 2011-05-06 19:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Harring (RETIRED) gentoo-dev 2011-05-03 12:44:49 UTC
Specifically within it's src_install, there is the following:

# Install examples
docinto examples
dodoc examples/* || die "dodoc failed"
docinto examples/simple
dodoc examples/simple/* || die "dodoc failed"

Think it's pretty obvious from the second dodoc, that the first will encounter a directory; however that ebuild is EAPI=3, and the rules of dodoc are "directories, without -r, are a nonzero exit".  You're not seeing it blow up because portage, go figure, broke compliance with the spec about 2 months back.

That issue is being sorted in 356389; meanwhile, the ebuild needs fixing.  I'd suggest just doing

dodoc -r examples/* || die "dodoc failed on examples/*"
Comment 1 Zac Medico gentoo-dev 2011-05-03 18:25:04 UTC
See bug 356389, comment #3. I can confirm that dev-python/pyopenssl-0.12 produces the following eqawarn log:

QA Notice: dodoc argument 'examples/simple' is a directory
Comment 2 Dirkjan Ochtman (RETIRED) gentoo-dev 2011-05-04 07:32:18 UTC
Your suggestion of dodoc -r doesn't actually seem to work:

dodoc -r examples/* || die "dodoc failed on examples/*"

results in:

 * QA Notice: file does not exist:
 *
 *      dodoc: -r does not exist
Comment 3 Zac Medico gentoo-dev 2011-05-04 16:03:39 UTC
(In reply to comment #2)
>  * QA Notice: file does not exist:
>  *
>  *      dodoc: -r does not exist

This is a quirk of trying to use dodoc -r with EAPI < 4. If you use EAPI 4 then it should work.
Comment 4 Dirkjan Ochtman (RETIRED) gentoo-dev 2011-05-04 16:35:09 UTC
So dodoc with directories started to fail in EAPI=3, but -r doesn't work until EAPI=4? That seems kind of... silly.
Comment 5 Zac Medico gentoo-dev 2011-05-04 16:46:48 UTC
(In reply to comment #4)
> So dodoc with directories started to fail in EAPI=3, but -r doesn't work until
> EAPI=4? That seems kind of... silly.

According to PMS it's supposed to fail in all EAPIs less that 4. It's effectively a break in backward-compatibility, as I mentioned in bug #356389, comment #13.
Comment 6 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2011-05-04 16:55:07 UTC
I replaced dodoc with doins.
Comment 7 Brian Harring (RETIRED) gentoo-dev 2011-05-06 19:33:23 UTC
(In reply to comment #4)
> So dodoc with directories started to fail in EAPI=3, but -r doesn't work until
> EAPI=4? That seems kind of... silly.

EAPI4 was when dodoc -r was added; pardon, I wasn't clear in the implicit eapi4 bump required for the ebuild...