Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 365655 - sys-apps/portage implicit pointer check is broken with gcc-4.5 and later
Summary: sys-apps/portage implicit pointer check is broken with gcc-4.5 and later
Status: CONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Unclassified (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-02 03:30 UTC by William Throwe
Modified: 2019-08-23 06:51 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description William Throwe 2011-05-02 03:30:32 UTC
gcc 4.5 enables -fshow-column by default, which breaks the regular expressions in /usr/lib64/portage/bin/check-implicit-pointer-usage.py

Replacing each "(\d+):" with "(\d+):(?:\d+:)?" seems to fix it and should still work with the old style messages, although I haven't done very much testing.

Reproducible: Always
Comment 1 Zac Medico gentoo-dev 2015-02-28 22:50:36 UTC
I've noticed this same issue with gcc-4.8. The relevant lines from the net-misc/openssh-6.7_p1-r3 build log with USE=X509 looked like this:

ssh-rsa.c: In function ‘ssh_rsa_sign’:
ssh-rsa.c:121:6: warning: assignment makes pointer from integer without a cast [enabled by default]
  sig = xmalloc(slen); /*fatal on error*/
      ^

It caused sshd to crash, as noted in the ChangeLog:

  27 Feb 2015; Patrick McLean <chutzpah@gentoo.org>
  +files/openssh-6.7_p1-xmalloc-include.patch, +openssh-6.7_p1-r4.ebuild:
  Add patch to fix crasher bug triggered on hardened x86_64 machines with
  USE=X509 and ancient clients.
Comment 2 Zac Medico gentoo-dev 2015-03-01 01:45:59 UTC
(In reply to William Throwe from comment #0)
> Replacing each "(\d+):" with "(\d+):(?:\d+:)?" seems to fix it and should
> still work with the old style messages, although I haven't done very much
> testing.

That appears to be a correct fix for the -fshow-column default.

However, I tested this with my build log from openssh-6.7_p1-r3 (see comment #1), and check-implicit-pointer-usage.py doesn't identify that warning as a problem because there's no "implicit declaration" message in the log. The log only contains a "makes pointer from integer" warning. So, I wonder if we should do something to remedy this.
Comment 3 Andreas K. Hüttel gentoo-dev 2018-06-20 21:45:52 UTC
Is this bug still relevant / is the check still broken?