365105 – app-accessibility/espeakup bad dependency on virtual/linux-sources

Bug 365105 - app-accessibility/espeakup bad dependency on virtual/linux-sources

Summary: app-accessibility/espeakup bad dependency on virtual/linux-sources

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal QA (vote)
Assignee:	William Hubbs

URL:
Whiteboard:
Keywords:	QAcanfix

Depends on:
Blocks:	118442
	Show dependency tree

Reported:	2011-04-27 16:55 UTC by Ulrich Müller
Modified:	2011-04-27 18:34 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Proposed patch for espeakup-0.71.ebuild (espeakup-0.71.ebuild.diff,1.05 KB, patch) 2011-04-27 16:55 UTC, Ulrich Müller	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ulrich Müller gentoo-dev

2011-04-27 16:55:00 UTC

Created attachment 271349 [details, diff]
Proposed patch for espeakup-0.71.ebuild

espeakup has a versioned dependency on virtual/linux-sources that is not allowed for an old-style virtual. Furthermore, a runtime dependency on kernel sources doesn't make much sense (and repoman warns about it).

I believe that the proper way to handle it would be via CONFIG_CHECK from linux-info.eclass. Suggested modification for espeakup-0.71.ebuild is attached. A similar change would have to be applied to the live ebuild.

Comment 1 William Hubbs gentoo-dev

2011-04-27 18:34:16 UTC

I took your patch and modified it a bit.

There are two options that we should check for, CONFIG_SPEAKUP and
CONFIG_SPEAKUP_SYNTH_SOFT both must be enabled. Also, I added error
messages with the ERROR_* options.

Thanks for the report and the patch.