Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 364033 - xf86-input-mtrack-0.1.0.ebuild (New Package)
Summary: xf86-input-mtrack-0.1.0.ebuild (New Package)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Default Assignee for New Packages
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2011-04-18 15:09 UTC by Ryan Bourgeois
Modified: 2011-05-13 00:27 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xf86-input-mtrack-0.1.0.ebuild (xf86-input-mtrack-0.1.0.ebuild,1021 bytes, text/plain)
2011-04-18 15:09 UTC, Ryan Bourgeois
Details
mtdev-1.1.0.ebuild (mtdev-1.1.0.ebuild,471 bytes, text/plain)
2011-04-18 15:11 UTC, Ryan Bourgeois
Details
xf86-input-mtrack-0.1.1.ebuild (xf86-input-mtrack-0.1.1.ebuild,1021 bytes, text/plain)
2011-04-28 06:51 UTC, Ryan Bourgeois
Details
my version of ebuild (xf86-input-mtrack-0.1.1.ebuild,1.15 KB, text/plain)
2011-05-07 11:13 UTC, Naohiro Aota
Details
sys-libs/mtdev-1.1.0.ebuild (mtdev-1.1.0.ebuild,424 bytes, text/plain)
2011-05-08 17:27 UTC, Naohiro Aota
Details
revised mtdev-1.1.0.ebuild (mtdev-1.1.0.ebuild,540 bytes, text/plain)
2011-05-10 06:38 UTC, Naohiro Aota
Details
xf86-input-mtrack-0.1.1-autoconf.patch (xf86-input-mtrack-0.1.1-autoconf.patch,2.72 KB, patch)
2011-05-11 23:27 UTC, Naohiro Aota
Details | Diff
xf86-input-mtrack-0.1.1.ebuild using xorg-2 (xf86-input-mtrack-0.1.1.ebuild,1.05 KB, text/plain)
2011-05-11 23:29 UTC, Naohiro Aota
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Bourgeois 2011-04-18 15:09:30 UTC
Created attachment 270385 [details]
xf86-input-mtrack-0.1.0.ebuild

Attached is xf86-input-mtrack-0.1.0.ebuild, an ebuild for the first release of the xf86-input-mtrack driver.

xf86-input-mtrack is a multitouch Xorg driver riginally intended to make functional the new Macbook trackpads with integrated button.  It will also work on other trackpads supporting the multitouch protocol.

The category should be x11-drivers.
Comment 1 Ryan Bourgeois 2011-04-18 15:11:17 UTC
Created attachment 270387 [details]
mtdev-1.1.0.ebuild

The mtdev library is a dependency of xf86-input-mtrack.  Also attached is mtdev-1.1.0.ebuild for that library.
Comment 2 Ryan Bourgeois 2011-04-28 06:51:59 UTC
Created attachment 271421 [details]
xf86-input-mtrack-0.1.1.ebuild

Attached is the new ebuild for v0.1.1 of the xf86-input-mtrack driver. The contents of the ebuild are identical to the old one, the version being bumped via the filename.
Comment 3 Naohiro Aota gentoo-dev 2011-05-07 11:13:29 UTC
Created attachment 272365 [details]
my version of ebuild

This is my version of ebuild. Fixed some errors (gcc, CFLAGS, LDFLAGS, lib vs lib64) and use github auto-generated tarball.

x11 team,
how do you think about category of mtdev. I think it would be better to be x11-libs/ (original ebuild categorized it to sys-libs/)
Comment 4 Tomáš Chvátal (RETIRED) gentoo-dev 2011-05-07 12:05:20 UTC
X11 team ebuilds must always use latest availible eapi, in this case 4. Please update your ebuilds with them.

For the driver just use xorg-2 eclass if possible.
Comment 5 Chí-Thanh Christopher Nguyễn gentoo-dev 2011-05-07 20:35:30 UTC
mtdev apparently uses no other parts of X (protos, headers, etc.) so it is not really related to other packages in x11-libs.
Comment 6 Naohiro Aota gentoo-dev 2011-05-08 07:09:51 UTC
(In reply to comment #4)
> X11 team ebuilds must always use latest availible eapi, in this case 4. Please
> update your ebuilds with them.

My ebuild is using eapi4. Are there some error with it? (attachment "my version of ebuild")

> For the driver just use xorg-2 eclass if possible.

Since this is a third-party driver, I don't think using xorg-2 eclass is better.

(In reply to comment #5)
> mtdev apparently uses no other parts of X (protos, headers, etc.) so it is not
> really related to other packages in x11-libs.

OK, I'll put it in sys-libs
Comment 7 Tomáš Chvátal (RETIRED) gentoo-dev 2011-05-08 11:07:08 UTC
You didn't attach mtdev ebuild i was complaining about :)
Comment 8 Naohiro Aota gentoo-dev 2011-05-08 17:27:42 UTC
Created attachment 272501 [details]
sys-libs/mtdev-1.1.0.ebuild

I see. Here is a EAPI=4 version of mtdev ebuild (almost the same)
Comment 9 Tomáš Chvátal (RETIRED) gentoo-dev 2011-05-09 09:46:54 UTC
(In reply to comment #8)
> Created attachment 272501 [details]
> sys-libs/mtdev-1.1.0.ebuild
> 
> I see. Here is a EAPI=4 version of mtdev ebuild (almost the same)

Use default src_install phase for eapi4...
Make static library optional or do not install it at all...
Drop the .la file completely.
Comment 10 Naohiro Aota gentoo-dev 2011-05-10 06:38:19 UTC
Created attachment 272701 [details]
revised mtdev-1.1.0.ebuild
Comment 11 Tomáš Chvátal (RETIRED) gentoo-dev 2011-05-10 09:36:00 UTC
sed -e 's:emake DESTDIR="${D}" install:default:'

Other than that feel free to commit mtdev to main tree with x11 as herd :)

FWIW on the xf86-input-mtrack really try to move it to xorg-2 eclass first
(also might be worth writting simple autoconf build (+-15 lines if you steal it from another xf86-input-something driver).
Comment 12 Naohiro Aota gentoo-dev 2011-05-11 23:27:10 UTC
Created attachment 272911 [details, diff]
xf86-input-mtrack-0.1.1-autoconf.patch
Comment 13 Naohiro Aota gentoo-dev 2011-05-11 23:29:56 UTC
Created attachment 272913 [details]
xf86-input-mtrack-0.1.1.ebuild using xorg-2

I've wrote an autoconf patch for mtrack package and xorg-2 using ebuild.
Please review them.
Comment 14 Tomáš Chvátal (RETIRED) gentoo-dev 2011-05-12 08:32:03 UTC
Drop the useless inherits xorg-2 is enough.

move the patch to PATCHES=() array in global scope thus dropping the src_prepare

Call the xorg-2_pkg_setup in pkg_setup phase.

Drop dependency over xinputproto and that xorg-server, both handled by eclass itself.

And feel free to commit that :)
Comment 15 Naohiro Aota gentoo-dev 2011-05-13 00:27:27 UTC
I've commit the ebuild. Thanks.