Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 363905 - [kde] The patch named kdeplasma-addons-4.6.2-optional-akonadi.patch breaks compilation of kdeplasma-addons-4.6.2 if lancelot has no akonadi
Summary: [kde] The patch named kdeplasma-addons-4.6.2-optional-akonadi.patch breaks co...
Status: RESOLVED DUPLICATE of bug 363585
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-17 08:13 UTC by David E. Narváez
Modified: 2011-04-17 20:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
emerge info (emergeinfo.txt,4.52 KB, text/plain)
2011-04-17 16:06 UTC, David E. Narváez 		Details
build.log (build.log,82.20 KB, text/plain)
2011-04-17 16:08 UTC, David E. Narváez 		Details
contactsrunner.cpp (contactsrunner.cpp,6.80 KB, text/plain)
2011-04-17 16:12 UTC, David E. Narváez 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David E. Narváez 2011-04-17 08:13:01 UTC 
The kdeplasma-addons-4.6.2-optional-akonadi patch adds a condition for adding the #include of akonadi/contact/contactdefaultactions.h as follows:

#ifdef LANCELOT_DATAMODELS_HAS_PIMLIBS
#include <akonadi/contact/contactdefaultactions.h>
#endif

but then Akonadi::CotactDefaultAction is used on line 183 without any conditions. I'd submit a patch but I have no idea of what should be the behavior in that case. Any ideas?

David E. Narváez

Reproducible: Always

Steps to Reproduce:
1. emerge --unmerge akonadi
2. emerge kdeplasma-addons
Actual Results:  
Compilation fails because Akonadi was not declared

Expected Results:  
Ebuild should compile fine
Comment 1 Theo Chatzimichos (RETIRED) archtester gentoo-dev Security 2011-04-17 09:40:19 UTC 
I need more info. In your step 1, you mention akonadi (I assume kde-base/akonadi) which is wrong, maybe you mean app-office/akonadi-server? Which package exactly fails? attach a build.log and emerge --info please.
Comment 2 David E. Narváez 2011-04-17 16:05:24 UTC 
(In reply to comment #1)
> I need more info. In your step 1, you mention akonadi (I assume
> kde-base/akonadi) which is wrong, maybe you mean app-office/akonadi-server?
> Which package exactly fails? attach a build.log and emerge --info please.

I just noticed I forgot to mention which was the problematic source file, sorry for that.

Well, I should have confirmed step 1 because I'm not sure of how to get LANCELOT_DATAMODELS_HAS_PMLIBS undefined, but the point of the bug is that if that symbol is undefined, line 183 of the file kdeplasma-addons-4.6.2/runners/contacts/contactsrunner.cpp still uses Akonadi::ContactDefaultAction without any conditions.

I'd say that's enough info, but anyhow, I'll be attaching the requested information.

David E. Narváez
Comment 3 David E. Narváez 2011-04-17 16:06:32 UTC 
Created attachment 270281 [details]
emerge info

Adding emerge --info
Comment 4 David E. Narváez 2011-04-17 16:08:03 UTC 
Created attachment 270283 [details]
build.log

Here's the build log, grep for the word Akonadi to see the error.
Comment 5 David E. Narváez 2011-04-17 16:12:40 UTC 
Created attachment 270285 [details]
contactsrunner.cpp

This is how the contactsrunner.cpp file looks after the patch is applied. Clearly, the use of Akonadi in line 183 is not possible if the LANCELOT_DATAMODELS_HAS_PMLIBS symbol is undefined and should be conditioned somehow.
Comment 6 Theo Chatzimichos (RETIRED) archtester gentoo-dev Security 2011-04-17 20:11:00 UTC 
see comment 9 of the dupe

*** This bug has been marked as a duplicate of bug 363585 ***