Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 362745 - dev-java/java-config-2.1.11-r3: java-nsplugin.eselect contains code in global scope
Summary: dev-java/java-config-2.1.11-r3: java-nsplugin.eselect contains code in global...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Java (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Java team
URL: http://www.gentoo.org/proj/en/eselect...
Whiteboard:
Keywords:
Depends on:
Blocks: eselect-java-tracker
  Show dependency tree
 
Reported: 2011-04-09 17:29 UTC by Ulrich Müller
Modified: 2016-01-01 23:03 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2011-04-09 17:29:23 UTC
java-nsplugin.eselect contains global scope code:

   libdirs=$(list_libdirs)
   if has lib32 ${libdirs} && has lib64 ${libdirs}; then
       IS_MULTILIB="true"
   else
       IS_MULTILIB="false"
   fi

This is not a good idea because it will slow down commands like "eselect help" (yes, this will source your module). See eselect's dev-guide at URL for details.

Please remove the global scope code from the module, e.g., move it to some function which can be called from do_* actions.
Comment 1 Ralph Sennhauser (RETIRED) gentoo-dev 2012-06-11 12:25:03 UTC
Fixed in vcs.
Comment 2 James Le Cuirot gentoo-dev 2016-01-01 23:03:30 UTC
This should have been closed years ago. java-nsplugin has gone in 0.2.0 anyway.