Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 362639 - media-gfx/inkscape-0.48.1 fails to build with gcc-4.6
Summary: media-gfx/inkscape-0.48.1 fails to build with gcc-4.6
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Graphics Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: gcc-4.6
  Show dependency tree
 
Reported: 2011-04-08 17:12 UTC by emil karlson
Modified: 2011-04-29 09:31 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for compilation with gcc-4.6 untested on older gcc (inkscape-gcc-4.6.diff,1.20 KB, patch)
2011-04-08 17:13 UTC, emil karlson
Details | Diff
A new patch with no --export-dynamic (inkscape-gcc-4.6.diff,1.18 KB, text/plain)
2011-04-11 20:41 UTC, emil karlson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description emil karlson 2011-04-08 17:12:02 UTC
fails to build due to:

--export-dynamic used without -Wl,

size_t missing

see patch

Reproducible: Always
Comment 1 emil karlson 2011-04-08 17:13:46 UTC
Created attachment 269051 [details, diff]
patch for compilation with gcc-4.6 untested on older gcc

patch for compilation with gcc-4.6, untested on older gcc
Comment 2 emil karlson 2011-04-08 18:01:33 UTC
upstreamed too:

https://bugs.launchpad.net/inkscape/+bug/754870
Comment 3 Konsta Hölttä 2011-04-08 18:02:58 UTC
Builds fine here with the patch. gcc-4.5.2.
Comment 4 Andrew John Hughes 2011-04-11 03:50:13 UTC
Also builds fine here.  Same patch but created by myself.  Why is this not in gcc-porting?
Comment 5 emil karlson 2011-04-11 17:12:30 UTC
(In reply to comment #4)
> Also builds fine here.  Same patch but created by myself.  Why is this not in
> gcc-porting?

This may or may not fail compile on osX and freebsd linkers, upstream may or may not have relied on some funny case of compiler ignoring --export-dynamic on some operating systems and actually taking it into account on some operatin systems...

Upstream is still discussing the issue and most people there don't seem to have a clue anymore than I have =o)

Reviewing the other upstreamed patch, it's essentially the same as my patch but a bit more bulky, perhaps some other configuration options required more modifications.
Comment 6 emil karlson 2011-04-11 20:41:28 UTC
Created attachment 269549 [details]
A new patch with no --export-dynamic

For all I know this patch behaviour is equivalent to that of gcc-4.5 and makes a lot more sense.

No one in upstream could explain the relevance of --export-dynamic on any system.

Tested under gnu/linux with gcc-4.5 and gcc-4.6.

Should also work on osX and freebsd, unlike the previous patch.
Comment 7 Tolga Dalman 2011-04-14 10:37:16 UTC
Is this bug fixed then ?
Comment 8 emil karlson 2011-04-14 12:44:12 UTC
(In reply to comment #7)
> Is this bug fixed then ?

Nope, upstream still silent and no patch has been included in portage.
Comment 9 Tolga Dalman 2011-04-14 13:26:00 UTC
(In reply to comment #8)
> (In reply to comment #7)
> > Is this bug fixed then ?
> 
> Nope, upstream still silent and no patch has been included in portage.

Since your patch apparently works on all current gcc versions, I would like to 
see a portage -r1 patch :-)

Regarding your patch: it looks good to me, however I'm also unsure about
--export-dynamic. Does -Wl,--export-dynamic work on gcc-4.6 ? If so, I
would prefer this former variant to match the upstream's original intention 
with --export-dynamic (whatever that might have been).

Thanks!
Comment 10 Ryan Hill (RETIRED) gentoo-dev 2011-04-22 04:25:50 UTC
-Wl,--export-dynamic doesn't work with non-gnu linkers.

Just drop it, it's been ignored by the gcc driver for a long time now.
Comment 11 Tim Harder gentoo-dev 2011-04-29 09:31:43 UTC
Fixed in the latest revbump in CVS, thanks.