Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 360527 - Please review and accept Prefix changes for dev-lang/parrot
Summary: Please review and accept Prefix changes for dev-lang/parrot
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All OS X
: Normal normal (vote)
Assignee: Gentoo Perl team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2011-03-26 10:27 UTC by Fabian Groffen
Modified: 2011-08-29 18:12 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Groffen gentoo-dev 2011-03-26 10:27:08 UTC
Please review the following small change to the parrot-3.0.0 ebuild:

@@ -28,6 +28,10 @@
 DEPEND="dev-lang/perl[doc?]
        ${RDEPEND}"
 
+src_prepare() {
+       epatch "${FILESDIR}"/${PN}-3.0.0-fix-darwin-link.patch
+}
+
 src_configure() {
        myconf="--disable-rpath"
        use unicode || myconf+=" --without-icu"


The darwin-link patch addresses a small problem that's isolated to Darwin only:

% cat files/parrot-3.0.0-fix-darwin-link.patch 
- set correct DYLD_LIBARY_PATH from build-system (instead of external from ebuild)
- don't probe for Fink and MacPorts libraries, we only want Gentoo Prefix' libs

--- parrot-2.3.0/config/gen/makefiles/root.in
+++ parrot-2.3.0/config/gen/makefiles/root.in
@@ -555,7 +555,7 @@
 
 # Libraries
 LIBPARROT_STATIC    = @blib_dir@/@libparrot_static@
-#IF(darwin):export DYLD_LIBRARY_PATH := @blib_dir@:$(DYLD_LIBRARY_PATH)
+#IF(darwin):export DYLD_LIBRARY_PATH := @build_dir@/@blib_dir@:$(DYLD_LIBRARY_PATH)
 #IF(win32):LIBPARROT_SHARED  = @libparrot_shared@
 #ELSE:LIBPARROT_SHARED  = @blib_dir@/@libparrot_shared@
 
--- parrot-2.3.0/config/init/hints/darwin.pm
+++ parrot-2.3.0/config/init/hints/darwin.pm
@@ -56,9 +56,6 @@
 
     $flagsref->{linkflags} .= " -undefined dynamic_lookup";
 
-    _probe_for_libraries($conf, $flagsref, 'fink');
-    _probe_for_libraries($conf, $flagsref, 'macports');
-
     for my $flag ( keys %$flagsref ) {
         $flagsref->{$flag} =~ s/^\s+//;
     }
Comment 1 Fabian Groffen gentoo-dev 2011-08-29 18:12:30 UTC
Large part of the patch was accepted upstream, last bit to disable macports and fink "support" was committed to the ebuild as sed.  Hope this is ok with you.