Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 359069 - sys-apps/openrc-0.6.8 (oldnet) deletes ppp ip/route when using "demand"
Summary: sys-apps/openrc-0.6.8 (oldnet) deletes ppp ip/route when using "demand"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: OpenRC Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-15 18:26 UTC by Ed Wildgoose
Modified: 2011-03-22 05:15 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Reintroduce previous fix for bug when using ppp + demand dialing (openrc-0.6.8-net.lo.patch,481 bytes, patch)
2011-03-15 18:26 UTC, Ed Wildgoose
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Wildgoose 2011-03-15 18:26:22 UTC
Created attachment 266007 [details, diff]
Reintroduce previous fix for bug when using ppp + demand dialing

It appears that somewhere along the way bug #145034 has been re-introduced into openrc?

The background is that if you use pppd with the "demand" option then pppd creates a default route and brings up the interface if it sees traffic on the link.  However, net.lo:stop() deletes all ip/routes associated with an interface, thus breaking the "demand" feature after the first dial/hangup round

It appears that Roy fixed this in baselayout 1.12.5, but either it never made it to openrc-2 or it has been lost along the way (sorry not checked the source repos)

The attached patch re-introduces Roy's fix from #145034, but also makes use of the IN_BACKGROUND variable to limit when we use this behaviour.

This change should be safe because largely PPP should be managing it's own IPs/routes anyway, openrc is really just being a touch over thorough in this case

Demand dialing is a less used feature, but some of us are still on dialup or have 3G connections that should not stay up except when required

Grateful if you could apply
Comment 1 William Hubbs gentoo-dev 2011-03-22 05:15:29 UTC
Your patch is applied in git, commit 60d8d4f.

Thanks for the report and patch.