Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 358987 - Eclass changes for Prefix to php-ext-source-r2.eclass
Summary: Eclass changes for Prefix to php-ext-source-r2.eclass
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All OS X
: Normal normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords: Inclusion, PATCH
: 383161 (view as bug list)
Depends on: 358985
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2011-03-15 10:19 UTC by nietonfir
Modified: 2015-09-06 21:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
prefixed pecl-imagick ebuild (pecl-imagick-3.0.1-r1.ebuild,737 bytes, text/plain)
2011-03-15 10:19 UTC, nietonfir
Details
prefixed php eclass for external libraries (php-ext-source-r2.eclass,10.51 KB, text/plain)
2011-03-15 10:20 UTC, nietonfir
Details
ebuild diff (pecl.diff,562 bytes, patch)
2011-03-15 10:21 UTC, nietonfir
Details | Diff
eclass diff (pecl.diff,562 bytes, patch)
2011-03-15 10:22 UTC, nietonfir
Details | Diff
eclass diff (eclass.diff,2.23 KB, patch)
2011-03-15 10:24 UTC, nietonfir
Details | Diff
eprefixified php-ext-source-v2.eclass (php-ext-source-r2.eclass,10.74 KB, text/plain)
2011-09-17 16:39 UTC, nietonfir
Details
eclass diff (php-ext-source-r2.prefix.patch,1.74 KB, patch)
2011-09-17 16:39 UTC, nietonfir
Details | Diff
eprefixified php-ext-source-v2.eclass (php-ext-source-r2.eclass,10.75 KB, text/plain)
2011-10-30 20:34 UTC, nietonfir
Details
eclass diff (php-ext-source-r2.eclass.diff,1.97 KB, patch)
2011-10-30 20:35 UTC, nietonfir
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nietonfir 2011-03-15 10:19:32 UTC
Created attachment 265917 [details]
prefixed pecl-imagick ebuild

I managed to change the ebuild and eclass in a way that imagick is emerged in a prefixed environment. Tested with a small code snippet from http://www.php.net/manual/en/function.imagickdraw-line.php#89980

I'd be nice if some could look through the changes in the eclass...
Only use flag used is php_targets_php5-3.
Comment 1 nietonfir 2011-03-15 10:20:47 UTC
Created attachment 265919 [details]
prefixed php eclass for external libraries
Comment 2 nietonfir 2011-03-15 10:21:13 UTC
Created attachment 265921 [details, diff]
ebuild diff
Comment 3 nietonfir 2011-03-15 10:22:27 UTC
Created attachment 265923 [details, diff]
eclass diff

This way it should be easier to review the changes.
Comment 4 nietonfir 2011-03-15 10:24:40 UTC
Created attachment 265925 [details, diff]
eclass diff

My wrong, picked the wrong diff, sry!
Comment 5 nietonfir 2011-09-15 23:15:20 UTC
*** Bug 383161 has been marked as a duplicate of this bug. ***
Comment 6 nietonfir 2011-09-17 16:39:12 UTC
Created attachment 286791 [details]
eprefixified php-ext-source-v2.eclass
Comment 7 nietonfir 2011-09-17 16:39:58 UTC
Created attachment 286793 [details, diff]
eclass diff

Updated diff of the new eclass
Comment 8 nietonfir 2011-10-30 20:34:20 UTC
Created attachment 291287 [details]
eprefixified php-ext-source-v2.eclass
Comment 9 nietonfir 2011-10-30 20:35:37 UTC
Created attachment 291289 [details, diff]
eclass diff

Is there anything wrong with the eprefixified eclass or this ebuild?
Comment 10 Fabian Groffen gentoo-dev 2011-10-30 20:50:23 UTC
Looks ok to me, apart from that we have to define EPREFIX when we want to use it and the EAPI is not 3 (or higher).

@php-bugs: how do you think about the patch, provided we add the definition for EPREFIX for older EAPIs?
Comment 11 Ole Markus With (RETIRED) gentoo-dev 2011-10-31 08:24:33 UTC
It looks good to me.
Comment 12 Christoph Junghans (RETIRED) gentoo-dev 2012-08-22 15:52:07 UTC
@grobian: have you ever committed the patch?
Comment 13 Fabian Groffen gentoo-dev 2012-08-22 16:20:56 UTC
no, because we need the bit suggested in comment #10, and it awaits approval in comment #11
Comment 14 Christoph Junghans (RETIRED) gentoo-dev 2012-08-23 15:31:45 UTC
(In reply to comment #13)
> no, because we need the bit suggested in comment #10, and it awaits approval
> in comment #11
The eclass in the current version supports EAPI=2,3,4  so 

has "${EAPI}" 2 && ! use prefix && EPREFIX=

should do the job, right?
Comment 15 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-08-23 15:50:48 UTC
(In reply to comment #14)
> (In reply to comment #13)
> > no, because we need the bit suggested in comment #10, and it awaits approval
> > in comment #11
> The eclass in the current version supports EAPI=2,3,4  so 
> 
> has "${EAPI}" 2 && ! use prefix && EPREFIX=
> 
> should do the job, right?

Yup.

I'll add a twist though, if you look at which ebuilds are EAPI2 or lower and inherit this eclass, there are not many. ESPECIALLY after cleaning up old versions: http://qa-reports.gentoo.org/output/eapi-per-eclass/php-ext-source-r2.eclass/2.txt Maybe the php team wants to clean up the old ebuild, migrate the remaining couple packages to EAPI>=3 then make the eclass only support EAPI>=3 ??
Comment 16 Ole Markus With (RETIRED) gentoo-dev 2012-08-23 15:58:28 UTC
Actually working on it right now :)
Comment 17 Ole Markus With (RETIRED) gentoo-dev 2013-04-22 07:05:23 UTC
(In reply to comment #16)
> Actually working on it right now :)

EAPI2 ebuilds have been gone from the tree for some time now.
Comment 18 Christoph Junghans (RETIRED) gentoo-dev 2014-03-18 17:18:57 UTC
The eclass is EAPI=[45] now, so applying attachment 291289 [details, diff] should be the only thing missing.
Comment 19 Michael Orlitzky gentoo-dev 2015-09-06 21:55:02 UTC
Sorry, I didn't realize this was here and committed more or less the same thing over in bug #371985.