Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 358935 - sys-auth/pam_usb removal request
Summary: sys-auth/pam_usb removal request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Petteri Räty (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 313389
  Show dependency tree
 
Reported: 2011-03-14 19:23 UTC by Samuli Suominen (RETIRED)
Modified: 2011-04-22 16:24 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Samuli Suominen (RETIRED) gentoo-dev 2011-03-14 19:23:35 UTC
The package doesn't look to be developed anymore and upstream mailinglist is full of spam.

We have 0.3.x series without sys-apps/hal depend that could in theory stay.  
Then we have 0.4.x series with sys-apps/hal for which this bug is for.

Should we remove the entire package? Just 0.4.x series? Or could someone at least query upstream about the package status?
Comment 1 Petteri Räty (RETIRED) gentoo-dev 2011-03-14 19:30:26 UTC
Well the upstream author has posted on the mailing list in February so I wouldn't say the project is inactive. Andrea: Is pam_usb actively developed? Presumably the intent here is to get you to migrate away from hal.
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2011-04-09 09:40:10 UTC
The package is gone.   Maybe bug 249110 would be replacement?
Comment 3 Andrea Luzzardi 2011-04-20 11:52:34 UTC
pam_usb is slowly but actively developed. I'm currently migrating the codebase away from HAL with a new UDisks based engine.
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2011-04-22 16:05:20 UTC
(In reply to comment #3)
> pam_usb is slowly but actively developed. I'm currently migrating the codebase
> away from HAL with a new UDisks based engine.

I've just restored pam_usb back to tree with 0.5.0's release.   The only question I have is... Why it's still using the deprecated `pmount` instead of `udisks --mount` ?
Comment 5 Andrea Luzzardi 2011-04-22 16:14:21 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > pam_usb is slowly but actively developed. I'm currently migrating the codebase
> > away from HAL with a new UDisks based engine.
> 
> I've just restored pam_usb back to tree with 0.5.0's release.   The only
> question I have is... Why it's still using the deprecated `pmount` instead of
> `udisks --mount` ?

One thing at a time :) I wanted to get rid of HAL ASAP, so I pushed the release as soon as the code base was moved to UDisks. pmount will go away by 0.5.1.
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2011-04-22 16:16:56 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > pam_usb is slowly but actively developed. I'm currently migrating the codebase
> > > away from HAL with a new UDisks based engine.
> > 
> > I've just restored pam_usb back to tree with 0.5.0's release.   The only
> > question I have is... Why it's still using the deprecated `pmount` instead of
> > `udisks --mount` ?
> 
> One thing at a time :) I wanted to get rid of HAL ASAP, so I pushed the release
> as soon as the code base was moved to UDisks. pmount will go away by 0.5.1.

And one more minor thing, we had this patch to support "openpam" for 0.4.2 and it never made upstream it seems:

--- src/pam.c
+++ src/pam.c
@@ -16,8 +16,12 @@
  */
 
 #define PAM_SM_AUTH
+
+#include <stdlib.h>
+#include <string.h>
+
 #include <security/pam_modules.h>
-#include <security/_pam_macros.h>
+#include <security/pam_appl.h>
 
 #include "version.h"
 #include "conf.h"

Still applies to 0.5.0
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2011-04-22 16:18:32 UTC
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-auth/pam_usb/files/pam_usb-0.4.2-openpam.patch?hideattic=0&view=log

^ The original patch.  I added string.h for strcmp()

> --- src/pam.c
> +++ src/pam.c
> @@ -16,8 +16,12 @@
>   */
> 
>  #define PAM_SM_AUTH
> +
> +#include <stdlib.h>
> +#include <string.h>
> +
>  #include <security/pam_modules.h>
> -#include <security/_pam_macros.h>
> +#include <security/pam_appl.h>
> 
>  #include "version.h"
>  #include "conf.h"
> 
> Still applies to 0.5.0
Comment 8 Andrea Luzzardi 2011-04-22 16:24:31 UTC
Thank Samuli, I don't remember seeing this one.

I'll make sure to include it for 0.5.1.
Or feel free to send it on github.

Either way is fine by me.

(In reply to comment #7)
> http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-auth/pam_usb/files/pam_usb-0.4.2-openpam.patch?hideattic=0&view=log
> 
> ^ The original patch.  I added string.h for strcmp()
> 
> > --- src/pam.c
> > +++ src/pam.c
> > @@ -16,8 +16,12 @@
> >   */
> > 
> >  #define PAM_SM_AUTH
> > +
> > +#include <stdlib.h>
> > +#include <string.h>
> > +
> >  #include <security/pam_modules.h>
> > -#include <security/_pam_macros.h>
> > +#include <security/pam_appl.h>
> > 
> >  #include "version.h"
> >  #include "conf.h"
> > 
> > Still applies to 0.5.0