Bug 358821 – Remove old-style virtual/aspell-dict

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Ulrich Müller 2011-03-14 11:05:50 UTC]

See tracker bug 350792.

virtual/aspell-dict
   packages (via aspell-dict.eclass):
      app-dicts/aspell-af
      app-dicts/aspell-be
      app-dicts/aspell-bg
      app-dicts/aspell-br
      app-dicts/aspell-ca
      app-dicts/aspell-cs
      app-dicts/aspell-cy
      app-dicts/aspell-da
      app-dicts/aspell-de
      app-dicts/aspell-de-alt
      app-dicts/aspell-el
      app-dicts/aspell-en
      app-dicts/aspell-eo
      app-dicts/aspell-es
      app-dicts/aspell-et
      app-dicts/aspell-fi
      app-dicts/aspell-fo
      app-dicts/aspell-fr
      app-dicts/aspell-ga
      app-dicts/aspell-gl
      app-dicts/aspell-he
      app-dicts/aspell-hr
      app-dicts/aspell-hu
      app-dicts/aspell-hy
      app-dicts/aspell-is
      app-dicts/aspell-it
      app-dicts/aspell-la
      app-dicts/aspell-lt
      app-dicts/aspell-nl
      app-dicts/aspell-no
      app-dicts/aspell-pl
      app-dicts/aspell-pt
      app-dicts/aspell-pt-br
      app-dicts/aspell-ro
      app-dicts/aspell-ru
      app-dicts/aspell-sk
      app-dicts/aspell-sl
      app-dicts/aspell-sr
      app-dicts/aspell-sv
      app-dicts/aspell-uk
      app-dicts/aspell-vi

This could easily be converted to a new-style virtual.

[Comment 1 Ulrich Müller 2011-04-08 06:07:05 UTC]

Thinking about this again: The current meaning of the virtual is "depend on some dictionary, but I don't care what language". That doesn't make much sense to me. In fact, app-text/aspell itself doesn't depend on the virtual, but carefully evaluates LINGUAS to compute its PDEPEND.

I went through the list of packages that depend on virtual/aspell-dict:

   app-editors/nedit
   app-office/lyx
   app-text/enchant
   app-text/winefish
   mail-client/balsa
   mail-client/cone
   mail-mta/courier

None of them accesses the dictionaries directly, but depends on them via aspell (typically, their configure will check for either aspell.h or libaspell).

So I believe we have two options (and I'd prefer the first one):

  1. Change above packages to depend on app-text/aspell, and drop the virtual
     entirely.
  2. Move the PDEPEND logic from the aspell ebuild to a new-style virtual, and
     have aspell depend on the virtual.

What do you think?

[Comment 2 David J Cozatt 2011-04-15 01:45:24 UTC]

A users perspective:

I'd prefer option one if the language dependency is satisfied automatically. As long as LINGUAS is set should be so if I grok this and anything that makes the tree smaller without breakage or feature loss is a no-brainer

[Comment 3 Ulrich Müller 2011-04-16 19:56:49 UTC]

(In reply to comment #1)
> So I believe we have two options (and I'd prefer the first one):
> 
>   1. Change above packages to depend on app-text/aspell, and drop the virtual
>      entirely.

No reply, so I've fixed this myself.