Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 35873 - GNUnet should allow "-gtk" USE flag
Summary: GNUnet should allow "-gtk" USE flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Jeremy Huddleston (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on: 45263
Blocks:
  Show dependency tree
 
Reported: 2003-12-15 06:52 UTC by Sebastian Spaeth
Modified: 2004-03-22 23:03 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Spaeth 2003-12-15 06:52:16 UTC
Currently the gnunet package depends on X,gtk, etc...
This is because of the GTK client. However, it is an optional client and can be disabled in ./configure. Therefore a "-X" USE flag should disable the building of the GTK client and remove the "X" dependency.
I am new to Gentoo and it will take a while to figure the (rather trivial) solution out. If somebody is faster than me... you are welcome to contribute this.
Comment 1 Sebastian Spaeth 2003-12-15 07:34:29 UTC
Turned out to be quite easy (portage seems really nice). I haven't tried it out to actually compile it. Will report here if anything breaks. I need help with the checkin (never did it, don't know the procedure).

One open issue (how do I determine the *default* state of a USE flag. I suppose 'gtk' should be turned on by default.

diff gnunet-0.6.0a.ebuild gnunet-0.6.0b.ebuild
21c21
<       =x11-libs/gtk+-1.2*
---
>       gtk? (=x11-libs/gtk+-1.2*)
26c26
<       econf `use_enable ipv6` || die
---
>       econf `use_with gtk` `use_enable ipv6` || die
Comment 2 Sebastian Spaeth 2003-12-15 07:45:07 UTC
adapt bug title to reflect reality. We need IUSE="gtk" not "X" here
Comment 3 Sebastian Spaeth 2003-12-15 08:38:03 UTC
Last post for now (sorry for the number of postings):
1) I compiled with and without gtk installed and everything went fine. So it works
2) Of course one should use "gtk? ( =x11-libs/gtk+-1.2* )" AND NOT 
   "gtk? (=x11-libs/gtk+-1.2*)" (as indicated in my diff)
3) I kept the gtk+ dependency as it was. I don't know whether it would work with gtk+2 as well. Probably it should be changed to ">=" ? (or leave it for now as is).

Thanks for considering my (first and probably clumsy) patch :)
Comment 4 Nick Hadaway 2004-01-29 22:20:50 UTC
I don't use this package... (yet!)  mholzer, as you were the last one to commit on gnunet... I bequeath this bug to you :)
Comment 5 Jeremy Huddleston (RETIRED) gentoo-dev 2004-03-22 23:03:01 UTC
gtk, mysql, and crypt USE flags added...