vlc-1.1.7 with USE=libnotify fails to build on my system. Line 315 in "modules/misc/notify/notify.c" contains a trailing ", NULL" too much.
fix - edit/patch modules/misc/notify/notify.c
< psz_temp, NULL, NULL );
> psz_temp, NULL );
Please include this patch so it works out of the box again. P.S.: I have not checked if this may have any side effects.
Created attachment 261642 [details, diff]
Fix compability with libnotify-0.7
This works with any of libnotify-0.4.x, 0.5.x, or 0.7.x
Would have committed it in Portage but the package is using patch tarball, so I'm leaving it to the maintainer to include.
@aballier: git is broken too, have not yet posted this upstream
please send the patch, i'll happily backport it and wont do anything until it reached upstream...
it'll take me less than a minute to send it too but you'll lose authorship
(In reply to comment #3)
> please send the patch, i'll happily backport it and wont do anything until it
> reached upstream...
> it'll take me less than a minute to send it too but you'll lose authorship
I don't care about credits. If you can submit it that'd be great.
Thank you for your work! Good job.
fixed upstream in git, backported to 1.1.7, thanks
(In reply to comment #6)
> fixed upstream in git, backported to 1.1.7, thanks
Version in portage still fails to compile, it has been failing now for a long time. Can't we just get the dependencies fixed while the new version arrives into portage?
$ diff -U3 /usr/portage/media-video/vlc/vlc-1.1.7.ebuild /var/lib/portage/local_overlay/media-video/vlc/vlc-1.1.7.ebuild
--- /usr/portage/media-video/vlc/vlc-1.1.7.ebuild 2011-02-19 13:31:18.000000000 +0100
+++ /var/lib/portage/local_overlay/media-video/vlc/vlc-1.1.7.ebuild 2011-03-15 23:18:06.773349851 +0100
@@ -91,7 +91,7 @@
kate? ( >=media-libs/libkate-0.1.1 )
libass? ( >=media-libs/libass-0.9.6 media-libs/fontconfig )
libcaca? ( >=media-libs/libcaca-0.99_beta14 )
- libnotify? ( x11-libs/libnotify )
+ libnotify? ( <x11-libs/libnotify-0.7 )
libproxy? ( net-libs/libproxy )
libtiger? ( media-libs/libtiger )
lirc? ( app-misc/lirc )
(In reply to comment #7)
> (In reply to comment #6)
> > fixed upstream in git, backported to 1.1.7, thanks
> Version in portage still fails to compile, it has been failing now for a long
> time. Can't we just get the dependencies fixed while the new version arrives
> into portage?
certainly not, last time i tried it was fixed anyway... maybe your tree is out of date