Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 352263 - www-client/chromium theme rdepends request for oxygen-icons (?)
Summary: www-client/chromium theme rdepends request for oxygen-icons (?)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Chromium Project
URL:
Whiteboard:
Keywords:
: 354715 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-01-20 18:25 UTC by Patrizio Bassi
Modified: 2011-03-10 19:45 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrizio Bassi 2011-01-20 18:25:13 UTC
i'm kde user with gnome-free environment i previously had x11-themes/oxygen-molecule i just substitured with oxygen-gtk

chrome is asking for one of
x11-themes/gnome-icon-theme
x11-themes/oxygen-molecule
x11-themes/tango-icon-theme
x11-themes/xfce4-icon-theme 

i'm wondering if possible to add oxygen-gtk too as i'm running with it and it looks perfect (or even better)
Comment 1 Dror Levin (RETIRED) gentoo-dev 2011-01-20 22:36:17 UTC
All the packages you mentioned which chromium depends on provide icons, whereas oxygen-gtk does not. For this reason oxygen-gtk could not be added as an alternative to those 4 packages. You would need to emerge one of those packages if you removed oxygen-molecule.

Side-note: As a KDE user myself who has gnome-icon-theme installed just for chromium, I can relate.
Comment 2 Patrizio Bassi 2011-01-22 16:13:49 UTC
but i tried with without the themes in the ebuild and it works perfectly without any icon missing, any black or "?" content typical when some gui parts are missing.

i'm talking of chromium 9.x version.

where is this dep documented?
Comment 3 Mike Gilbert gentoo-dev 2011-01-22 19:27:10 UTC
(In reply to comment #2)
> where is this dep documented?
> 

See bug 292201.
Comment 4 Patrizio Bassi 2011-01-22 19:28:44 UTC
ok if it's still valid, i'm fine, thx
Comment 5 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2011-02-16 07:18:59 UTC
*** Bug 354715 has been marked as a duplicate of this bug. ***
Comment 6 Nikoli 2011-02-16 09:50:18 UTC
>All the packages you mentioned which chromium depends on provide icons

You are wrong, x11-themes/oxygen-molecule does not provide any icons, but uses icons from kde-base/oxygen-icons. Same with x11-themes/oxygen-gtk.
Comment 7 Patrizio Bassi 2011-02-16 09:54:42 UTC
infact for me without molecule but oxygen-gtk it works perfectly.

do you want me to reopen? Pawel?
Comment 8 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2011-02-16 09:57:13 UTC
Re-opening, maybe we should rdepend on oxygen-icons.
Comment 9 Patrizio Bassi 2011-02-16 09:58:50 UTC
ok...i'm kde user so it's fine...just take a look at deps because it's
possibile oxygen-icons will pull kdebase packages (bad for gnome users)
Comment 10 Nikoli 2011-02-16 10:04:23 UTC
x11-themes/oxygen-molecule has kde-base/oxygen-icons in RDEPEND, but x11-themes/oxygen-gtk does not.
Comment 11 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2011-02-22 18:29:13 UTC
I investigated the issue more closely, and it seems that only xfce4-icon-theme and gnome-icon-theme satisfy the dependency. I have removed other themes from RDEPEND.

It is important to test the Downloads page with some downloads (they should have icons). Also, the browser should be restarted between tests to be sure it doesn't keep the old icons in memory.

Short story: just the fact that the browser launches and doesn't look obviously wrong doesn't prove some package satisfies the icon theme dependency.
Comment 12 Mike Gilbert gentoo-dev 2011-02-22 19:55:19 UTC
Just reposting a comment I made via email:

I'm not sure it is quite so simple. From what I can tell, chromium
will use whatever icon theme you have selected. For example, I'm
running KDE4 with the oxygen theme selected, and I see oxygen icons on
the downloads page.

Also, if I move /usr/share/icons/oxygen out of the way and run
chromium, I get broken images on the downloads page.
Comment 13 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2011-02-24 07:58:56 UTC
(In reply to comment #12)
> I'm not sure it is quite so simple. From what I can tell, chromium
> will use whatever icon theme you have selected. For example, I'm
> running KDE4 with the oxygen theme selected, and I see oxygen icons on
> the downloads page.

That's crazy! I traced the code a bit, and it seems to use xdg_mime_get_icon to get the icon. I'll read more about it, and do tests inside KDE.

The dependencies may then flip a little bit, sorry about that. Thank you for detecting this interesting behavior.
Comment 14 MrPenguin07 2011-03-05 07:18:02 UTC
I too have been puzzled by this one and decided to investigate.

From what I can tell chromium is only using kde4/oxygen icons - i've actually deleted the /usr/share/icons/gnome dir (it's over 100mb of wasted space!) - while keeping gnome-icon-theme "installed" to no ill effects. Obviously not a solution but I can't mask it without portage complaints.

As for how to remedy this, surely we can just remove gnome-icon-theme from the dep list when using -gnome? or less preferably a virtual package?
Comment 15 Patrizio Bassi 2011-03-05 11:11:19 UTC
i totally agree.

as kde-only user i refuse to pull gnome deps just for an hypotetic icon.
I see nothing wrong here without it (i injected the gnome deps to make portage happy) but anyhow we may even pull out the download icon only and attach to chromium build only.
Comment 16 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2011-03-10 19:45:49 UTC
Should be fixed now, switched to elog messages. Thanks everyone.