Bug 350183 – edbrowse-3.4.5.ebuild (New Package)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Christopher Brannon (RETIRED) 2010-12-30 20:22:34 UTC]

Attached is an ebuild for Karl Dhalke's edbrowse utility.
Here is its long description.

Edbrowse is many things: editor, web browser, email client, and even
a tool for manipulating databases.  It uses the same interface as the
venerable /bin/ed editor.
Although it was originally written for blind users, others have used
it as a scriptable web client.
Karl Dahlke is its primary author and maintainer.

I suggest a category of either www-client or app-accessibility, although
app-editors might also be appropriate.  Also note that it is not a drop-in
replacement for /bin/ed, mainly because it uses Perl-compatible regular
expressions.

[Comment 1 Christopher Brannon (RETIRED) 2010-12-30 20:23:05 UTC]

Created attachment 258466 [details]
edbrowse-3.4.5.ebuild

[Comment 2 Christopher Brannon (RETIRED) 2010-12-30 20:23:36 UTC]

Created attachment 258468 [details, diff]
edbrowse-3.4.5-fix-makefile.patch

[Comment 3 William Hubbs 2011-01-02 18:07:03 UTC]

I found some things in this ebuild:

- The header line (line 3) should read "$Header: $", it looks like you
  have an old header there.
  - you are using cd and pushd/popd in the ebuild.  I recommend just
	using cd to move between directories. If you want to use pushd/popd,
	remember to redirect the output from those to /dev/null.
	- Normally, in src_install, we do the make portion of the install
	  before we use do* functions to install individual files.

Can you send an update to the ebuild addressing these?

Thanks,

William

[Comment 4 William Hubbs 2011-01-08 18:05:25 UTC]

Hi Chris,

I'm just pinging this bug to see if you have seen my most recent
suggestions for changes.

Can you please update the ebuild and re-attach it?

Thanks,

William

[Comment 5 Christopher Brannon (RETIRED) 2011-01-09 16:31:30 UTC]

Created attachment 259378 [details]
edbrowse-3.4.5.ebuild

Here is my updated ebuild.  The aforementioned mistakes are corrected.

Also, note that there is a known bug in version 3.4.5, having to do with
text substitutions on very large files (500000 lines or more).
I'm not sure when 3.4.6 is due.

Thanks,
-- Chris

[Comment 6 William Hubbs 2011-01-20 05:48:25 UTC]

Hi Chris,

lines 16-20 and 50  should start with 1 tab, but you have more
whitespace than this at the beginning of these lines.

If you want to fix those and re-attach the ebuild, we will be ready to
go.

[Comment 7 Christopher Brannon (RETIRED) 2011-01-20 16:50:17 UTC]

Version 3.4.6 is on its way, with an important bugfix.  I'll just upload
an ebuild for it as soon as it's released.  Sorry about the whitespace
errors.

-- Chris

[Comment 8 Christopher Brannon (RETIRED) 2011-02-23 01:54:32 UTC]

Created attachment 263579 [details]
edbrowse-3.4.6.ebuild

ebuild for edbrowse-3.4.6.

[Comment 9 Christopher Brannon (RETIRED) 2011-02-23 01:55:10 UTC]

Created attachment 263581 [details, diff]
edbrowse-3.4.6-fix-makefile.patch

Patch for the makefile.

[Comment 10 Christopher Brannon (RETIRED) 2011-02-23 01:55:38 UTC]

Created attachment 263583 [details, diff]
edbrowse-3.4.6-fix-off-by-one.patch

Fix for an off-by-one error.

[Comment 11 William Hubbs 2011-02-23 23:21:33 UTC]

This has been added to the tree. Thanks for the submission.

[Comment 12 William Hubbs 2011-02-23 23:22:04 UTC]

closing.