Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 349763 - sys-fs/multipath-tools-0.4.9-r1 fails with forced --as-needed
Summary: sys-fs/multipath-tools-0.4.9-r1 fails with forced --as-needed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Gentoo's Team for Core System packages
URL: http://www.gentoo.org/proj/en/qa/asne...
Whiteboard:
Keywords:
Depends on:
Blocks: as-needed
  Show dependency tree
 
Reported: 2010-12-26 14:31 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2012-05-22 15:04 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Build log (multipath-tools-0.4.9-r1:20101226-105654.log,12.48 KB, text/plain)
2010-12-26 14:32 UTC, Diego Elio Pettenò (RETIRED) 		Details
fixing as-needed issues, respecting LDFLAGS (multipath-tools-ldflags_asneeded.patch,1.44 KB, patch)
2010-12-28 18:34 UTC, Kacper Kowalik (Xarthisius) (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-12-26 14:31:56 UTC 
I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Please note that this bug _might_ apply to -Wl,--as-needed in LDFLAGS as well; in both cases it should be fixed. Also, if this is due to the package in question not respecting user-defined LDFLAGS, you should get to fix that too.

Check the attached build log.

Thanks,
Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-12-26 14:32:15 UTC 
Created attachment 258101 [details]
Build log
Comment 2 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2010-12-28 18:34:29 UTC 
Created attachment 258276 [details, diff]
fixing as-needed issues, respecting LDFLAGS

I've send the patch upstream.
Comment 3 David J Cozatt 2011-06-07 05:52:42 UTC 
sys-fs/multipath-tools-0.4.9-r2 - 06/06/11

QA: other                                                                            │
│^[[31;01mQA Notice: Files built without respecting LDFLAGS have been detected^[[0m   │
│ Please include the following list of files in your report:                          │
│/lib64/libmultipath.so.0                                                             │
│/lib64/multipath/libcheckrdac.so     
 | /lib64/multipath/libcheckcciss_tur.so                                                │
│/lib64/multipath/libpriordac.so                                                      │
│/lib64/multipath/libprioalua.so                                                      │
│/lib64/multipath/libcheckdirectio.so                                                 │
│/lib64/multipath/libcheckemc_clariion.so                                             │
│/lib64/multipath/libcheckreadsector0.so                                              │
│/lib64/multipath/libprioconst.so                                                     │
│/lib64/multipath/libpriodatacore.so                                                  │
│/lib64/multipath/libprioemc.so                                                       │
│/lib64/multipath/libpriorandom.so                                                    │
│/lib64/multipath/libpriohds.so                                                       │
│/lib64/multipath/libchecktur.so                                                      │
│/lib64/multipath/libcheckhp_sw.so                                                    │
│/lib64/multipath/libpriohp_sw.so                                                     │
│/lib64/multipath/libprionetapp.so
Comment 4 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2012-05-22 15:04:16 UTC 
 22 May 2012; Kacper Kowalik <xarthisius@gentoo.org>
  files/multipath-tools-0.4.9-build.patch:
  Fix as-needed error introduced in previous commit. Fixes bug #413171 by Harris
  Landgarten

 21 Apr 2012; Mike Frysinger <vapier@gentoo.org>
  files/multipath-tools-0.4.9-build.patch:
  Respect LDFLAGS when linking shared libs.